Fix declaration-block-no-shorthand-property-overrides false negatives for font and border
#7606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5bf2f29 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Mouvedia
commented
Apr 12, 2024
Mouvedia
commented
Apr 12, 2024
lib/rules/declaration-block-no-shorthand-property-overrides/index.mjs
Outdated
Show resolved
Hide resolved
Mouvedia
commented
Apr 12, 2024
Mouvedia
force-pushed
the
fix-shorthand-border-font
branch
from
e7b3d80
to
23cbaeb
Compare
Mouvedia
force-pushed
the
fix-shorthand-border-font
branch
from
23cbaeb
to
3175dad
Compare
…es for `font` and `border`
Mouvedia
force-pushed
the
fix-shorthand-border-font
branch
from
3175dad
to
ccbc604
Compare
ybiquitous
requested changes
Apr 17, 2024
There was a problem hiding this comment.
@Mouvedia Thanks for the pull request, and sorry for the late response. I have been very busy since last week.
I just left some suggestions. Can you take a look?
lib/rules/declaration-block-no-shorthand-property-overrides/index.mjs
Outdated
Show resolved
Hide resolved
Mouvedia
force-pushed
the
fix-shorthand-border-font
branch
from
1564f4c
to
e53937c
Compare
ybiquitous
requested changes
Apr 17, 2024
lib/rules/declaration-block-no-shorthand-property-overrides/index.mjs
Outdated
Show resolved
Hide resolved
lib/rules/declaration-block-no-shorthand-property-overrides/index.mjs
Outdated
Show resolved
Hide resolved
Mouvedia
commented
Apr 18, 2024
Merged
emmacharp
pushed a commit
to emmacharp/stylelint
that referenced
this pull request
May 7, 2024
…es for `font` and `border` (stylelint#7606)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7586
followup of #7585
borderresetsborder-imagewhich itself resets its own longhandssee https://www.w3.org/TR/css-backgrounds-3/#border-image
font-variantaddition is covered by #7620see https://github.com/stylelint/stylelint/pull/7606/files#diff-95fc42ab5cb27ff75b1ed1b46186e75f13e8fad2bfb54491d1c3fc4a478c0461R211