Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex support to ignoreValues for value-no-vendor-prefix #7650

Merged
merged 6 commits into from Apr 25, 2024

Conversation

Mouvedia
Copy link
Contributor

@Mouvedia Mouvedia commented Apr 25, 2024

Which issue, if any, is this issue related to?

Closes #7645

Is there anything in the PR that needs further explanation?

The previously non-documented partial regex support that performed the comparison on the unprefixed value has been scrapped in favor of a documented support which compares exactly.
cf 8a1a968 (#3015)

Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: ea57202

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Mouvedia Mouvedia marked this pull request as draft April 25, 2024 12:32
@Mouvedia Mouvedia marked this pull request as ready for review April 25, 2024 12:49
The previously non-documented partial regex support that performed the comparison on the unprefixed value has been scrapped in favor of a documented support which compares exactly.
@ybiquitous ybiquitous changed the title Add regex support to value-no-vendor-prefix secondary option Add regex support to ignoreValues for value-no-vendor-prefix Apr 25, 2024
@Mouvedia
Copy link
Contributor Author

error - 2024-04-25 13:03:37,676 -- Commit creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 850 seconds."}

@ybiquitous In the meantime, you can review.

@ybiquitous
Copy link
Member

#7650 (comment)

Probably, forked branches cannot read secrets stored in the repository, such as a Codecov token.

lib/rules/value-no-vendor-prefix/index.mjs Outdated Show resolved Hide resolved
lib/rules/value-no-vendor-prefix/README.md Outdated Show resolved Hide resolved
lib/rules/value-no-vendor-prefix/index.mjs Outdated Show resolved Hide resolved
Mouvedia and others added 2 commits April 25, 2024 15:48
Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>
Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 👍🏼

@Mouvedia Mouvedia merged commit c4c1816 into stylelint:main Apr 25, 2024
17 checks passed
emmacharp pushed a commit to emmacharp/stylelint that referenced this pull request May 7, 2024
…lelint#7650)

The previously non-documented partial regex support that performed the comparison on the unprefixed value has been scrapped in favor of a documented support which compares exactly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add regex support to value-no-vendor-prefix secondary option
2 participants