Fix `value-no-vendor-prefix` false negatives #7654

Mouvedia · 2024-04-25T20:44:31Z

Which issue, if any, is this issue related to?

related to #7624

Is there anything in the PR that needs further explanation?

While working on #7624 I realised how the rule was intended to work. We can't change that behaviour after the fact.
It reports if the value can be unprefixed safely, else it bails-out.

In practice this is what you want and actually that's better for us: we don't have to update stylelint-config-standard with an -apple-system exception anymore because it is not an unprefixable value.

This PR mainly fixes the documentation and some false negatives.
We can close #7624 after that because it's not on scope with the rule.
I didn't add all the missing values; I might some day.
I couldn't find use cases for -konq- so I left it out.

changeset-bot · 2024-04-25T20:44:34Z

🦋 Changeset detected

Latest commit: f5f8186

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
stylelint	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Mouvedia · 2024-04-25T21:24:13Z

lib/rules/value-no-vendor-prefix/README.md

@@ -9,7 +9,7 @@ a { display: -webkit-flex; }
 *  This prefix */
 ```

-This rule ignores non-standard vendor-prefixed values that aren't handled by [Autoprefixer](https://github.com/postcss/autoprefixer).
+This rule does not fix vendor-prefixed values that weren't handled by [Autoprefixer](https://github.com/postcss/autoprefixer) version 10.2.5. Exceptions may be added on a case by case basis.


I have added some examples of such cases that happen to be the false negatives that I am fixing in this PR.
see https://github.com/stylelint/stylelint/pull/7654/files#diff-db7ee227393b97a75cdd1e359512825b05fc5e14bfd94e304762622814f41a14

Mouvedia · 2024-04-25T21:25:05Z

lib/rules/value-no-vendor-prefix/README.md

@@ -9,7 +9,7 @@ a { display: -webkit-flex; }
 *  This prefix */
 ```

-This rule ignores non-standard vendor-prefixed values that aren't handled by [Autoprefixer](https://github.com/postcss/autoprefixer).
+This rule does not fix vendor-prefixed values that weren't handled by [Autoprefixer](https://github.com/postcss/autoprefixer) version 10.2.5. Exceptions may be added on a case by case basis.


For the version check #5312 (comment)

Mouvedia · 2024-04-25T21:28:03Z

lib/rules/value-no-vendor-prefix/README.md

@@ -75,11 +75,6 @@ a { cursor: -webkit-grab; }
 a { list-style-type: -moz-hangul; }
 ```

-<!-- prettier-ignore -->
-```css
-a { list-style-type: -moz-hangul-consonant; }


This was technically true that it was being ignored but it was misleading.
i.e. it was ignored because it wasn't part of the variables that are considered unprefixable
see https://github.com/stylelint/stylelint/pull/7654/files#diff-5f9be0b5e6e40c3ad07fc3db2a8895c25da53046e10664c0112bbb9e237893c5R295

Mouvedia · 2024-04-25T21:29:12Z

lib/rules/value-no-vendor-prefix/__tests__/index.mjs

+			code: 'a { white-space: -pre-wrap; }',
+			description: 'ignores non-vendor prefixed values',


see https://web.archive.org/web/20100502064159/http://users.tkk.fi:80/tkarvine/pre-wrap-css3-mozilla-opera-ie.html

Mouvedia · 2024-04-25T21:29:50Z

lib/rules/value-no-vendor-prefix/__tests__/index.mjs

+			code: '.foo { display: -khtml-box; }',
+			fixed: '.foo { display: box; }',


see Igalia/webkit@a659cc2#diff-29c17e702b85143afffde80667b4c59b196f34d765b2f77e1586d3c3de7f1679

Mouvedia · 2024-04-25T21:30:41Z

lib/rules/value-no-vendor-prefix/__tests__/index.mjs

+			code: '.foo { speak: -xv-digits; }',
+			fixed: '.foo { speak: digits; }',


see https://issues.chromium.org/issues/40813740

Mouvedia · 2024-04-25T22:00:11Z

lib/rules/value-no-vendor-prefix/__tests__/index.mjs

+			code: '.foo { -webkit-user-select: -moz-all; }',
+			fixed: '.foo { -webkit-user-select: all; }',


see https://bugzilla.mozilla.org/show_bug.cgi?id=1492958

Mouvedia · 2024-04-25T22:01:25Z

lib/rules/value-no-vendor-prefix/README.md

 ```

 <!-- prettier-ignore -->
 ```css
-a { -webkit-appearance: -apple-pay-button; }
+a { -moz-user-select: -moz-all; }


The previous example was misleading, -apple-pay-button is always ignored.

Mouvedia · 2024-04-25T22:03:27Z

lib/reference/prefixes.mjs

+	'-o-',
+	'-xv-',
+	'-apple-',
+	'-wap-',


see https://www.developershome.com/wap/wcss/wcss_tutorial.asp?page=marqueeExtension

Mouvedia · 2024-04-25T22:19:46Z

lib/reference/prefixes.mjs

+	'-xv-',
+	'-apple-',
+	'-wap-',
+	'-khtml-',


e.g. :-khtml-drag

ybiquitous

Thanks, overall LGTM. I've left a few suggestions only for the changelog.

.changeset/serious-bees-burn.md

Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>

ybiquitous

LGTM 👍🏼

Mouvedia changed the title ~~Fix value/selector-no-vendor-prefix false negatives~~ Fix value/selector-no-vendor-prefix false negatives [WIP] Apr 25, 2024

Mouvedia force-pushed the fix-false-vnvp-snvp branch from 542b374 to 9556da2 Compare April 25, 2024 21:21

Mouvedia changed the title ~~Fix value/selector-no-vendor-prefix false negatives [WIP]~~ Fix value-no-vendor-prefix false negatives Apr 25, 2024

Mouvedia commented Apr 25, 2024

View reviewed changes

Mouvedia force-pushed the fix-false-vnvp-snvp branch from 9556da2 to afe1a6f Compare April 25, 2024 21:55

Fix value-no-vendor-prefix false negatives

0600e66

Mouvedia force-pushed the fix-false-vnvp-snvp branch from afe1a6f to 0600e66 Compare April 25, 2024 21:59

Mouvedia commented Apr 25, 2024

View reviewed changes

lib/reference/prefixes.mjs

'-xv-',

'-apple-',

'-wap-',

'-khtml-',

Copy link

Member Author

Mouvedia Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. :-khtml-drag

Mouvedia marked this pull request as ready for review April 25, 2024 22:24

Mouvedia requested a review from ybiquitous April 25, 2024 22:47

ybiquitous reviewed Apr 25, 2024

View reviewed changes

.changeset/serious-bees-burn.md Outdated Show resolved Hide resolved

.changeset/serious-bees-burn.md Outdated Show resolved Hide resolved

Apply suggestions from code review

f5f8186

Co-authored-by: Masafumi Koba <473530+ybiquitous@users.noreply.github.com>

ybiquitous approved these changes Apr 25, 2024

View reviewed changes

Mouvedia merged commit 68cb920 into stylelint:main Apr 25, 2024
17 checks passed

Mouvedia deleted the fix-false-vnvp-snvp branch April 25, 2024 23:44

Mouvedia mentioned this pull request Apr 27, 2024

Fix value-no-vendor-prefix false positives/negatives #7658

Merged

emmacharp pushed a commit to emmacharp/stylelint that referenced this pull request May 7, 2024

Fix value-no-vendor-prefix false negatives (stylelint#7654)

d40a3e9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `value-no-vendor-prefix` false negatives #7654

Fix `value-no-vendor-prefix` false negatives #7654

Mouvedia commented Apr 25, 2024 •

edited

changeset-bot bot commented Apr 25, 2024 •

edited

Mouvedia Apr 25, 2024

Mouvedia Apr 25, 2024

Mouvedia Apr 25, 2024

Mouvedia Apr 25, 2024

Mouvedia Apr 25, 2024

Mouvedia Apr 25, 2024

Mouvedia Apr 25, 2024

Mouvedia Apr 25, 2024

Mouvedia Apr 25, 2024

Mouvedia Apr 25, 2024

ybiquitous left a comment

ybiquitous left a comment

		code: 'a { white-space: -pre-wrap; }',
		description: 'ignores non-vendor prefixed values',

		code: '.foo { display: -khtml-box; }',
		fixed: '.foo { display: box; }',

		code: '.foo { speak: -xv-digits; }',
		fixed: '.foo { speak: digits; }',

		code: '.foo { -webkit-user-select: -moz-all; }',
		fixed: '.foo { -webkit-user-select: all; }',

Fix value-no-vendor-prefix false negatives #7654

Fix value-no-vendor-prefix false negatives #7654

Conversation

Mouvedia commented Apr 25, 2024 • edited

changeset-bot bot commented Apr 25, 2024 • edited

🦋 Changeset detected

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ybiquitous left a comment

Choose a reason for hiding this comment

ybiquitous left a comment

Choose a reason for hiding this comment

Fix `value-no-vendor-prefix` false negatives #7654

Fix `value-no-vendor-prefix` false negatives #7654

Mouvedia commented Apr 25, 2024 •

edited

changeset-bot bot commented Apr 25, 2024 •

edited