flex: basis-size and full flex shorthand support #118
+28
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,9 +20,6 @@ align-content() | |||
| align-self() | |||
| vendor('align-self', arguments, only: webkit official) | |||
|
|
|||
| flex-basis() | |||
There was a problem hiding this comment.
Moved down to translated section.
Closed
|
anyone have comments on this? I haven't fooled with the flex-box stuff much yet, last time I checked it was pretty buggy in general |
|
Can I use FlexBox? (Dark green: obsolete and/or buggy, Light green: new) The obsolete model is relatively well supported (still buggy in some browsers). The new one isn't, but will be in the future and is the definitive way to go. But of course, I'd like to hear further opinions on this! |
|
I think you'll need to add |
|
Yup, you're right. I didn't add this file to the commit. Do you want to PR or shall I do it? |
|
I just created one at #126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New translations!
basis-sizenow works with awidth/heighthack.flexnow works as complete as possible. It supports all shorthand syntax versions defined in MDN and interprets<'flex-grow'>and<'flex-basis'>. We can't support<'flex-shrink'>due to technical limitations of the old specifications.New properties, that are still untranslated:
align-contentalgin-selfflex-shrinkflex-wrapjustify-content