Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoprefixer Integration #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Autoprefixer Integration #223

wants to merge 1 commit into from

Conversation

jescalan
Copy link

This PR will integrate autoprefixer into nib by default, and remove a lot of vendor maintenance stuff. Initial commit here just adds it to the pipeline, a lot of work still left to carefully strip the vendor-handling pieces from nib without breaking anything or removing functionality like the node-canvas stuff.

@notslang
Copy link
Collaborator

This is a nice start, but the tests are failing and we should gut out all the prefixing that nib does before we merge this. That way we're not prefixing twice, which could either cause performance degradation, errors, or both.

@jescalan
Copy link
Author

Definitely, this is not intended as a full implementation, just getting the ball rolling. What are your thoughts on how to handle gradients? Autoprefixer has handling for gradients, but I know nib does image replacement as well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants