Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS4 selectors added #2626

Closed
wants to merge 4 commits into from
Closed

CSS4 selectors added #2626

wants to merge 4 commits into from

Conversation

futekov
Copy link
Contributor

@futekov futekov commented Aug 24, 2021

Attempt to fix #2594

Adding :is :has and :where pseudo selectors
Copy link
Member

@iChenLei iChenLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, futekov. Can you add unit test cases ? Thanks, same with 490d117

lib/parser.js Show resolved Hide resolved
now all 378 tests pass successfully, was failing due to wrong indentation
@iChenLei
Copy link
Member

@groenroos If you have some times, please help me review this pull request. Looks good overall, but i think test cases are too simple, and exist a case not passed.

//  throws illegal unary "==", missing left-hand operand
//  input:is
//  span
//    color #015

@iChenLei
Copy link
Member

closed by #2684

@iChenLei iChenLei closed this May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Compound modern class selector doesn't get compiled if nested or inside at-rule
2 participants