add support for CSS Values 4 viewport-relative units #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for stylus-docs canceled.
|
iChenLei
requested changes
Mar 14, 2023
There was a problem hiding this comment.
Please add unit tests for CSS Values 4 viewport-relative units
, Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
The MR adds support for viewport-relative units from CSS Values 4 (WD), which became the de-facto standard by being supported by all major browsers now.
Why:
It would be nice to enable people to use these units in their code.
How:
The array of units ( in
./lib/units.js) was extended to support the new values.Checklist: