chore: Remove node v10 and v12 which are EOL #2834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for stylus-docs canceled.
|
|
Feel free to change the wording in the changelog, I'm not quite sure if you want it to say "dropped support" or simply that they're no longer being tested for? I suppose considering how few users are probably on these very old versions and that the project is in a version <1.0.0 it doesn't matter much. |
|
Thank you. |
|
@iChenLei Can I get an approve or a merge? :) |
@richardsimko I will handle this PR over the weekend |
|
Awesome, thank you! |
iChenLei
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Removed node v10 and v12 from test matrix according to the conversation here: #2818 (comment)
Why: Both 10 and 12 are EOL since 2.5 and 1.5 years respectively. Test cases are failing when trying to update
@adobe/css-toolsto a version that's not vulnerable.Checklist: