Fix Super Calls #2839
Closed
Fix Super Calls #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the super.operate.call syntax doesn't pass in the `this` argument. The code before the classes #2813 PR was: ```js Node.prototype.operate.call(this, op, right) ``` and the code was incorrectly transformed into ```js super.operate.call(op, right); ```
instead of doing `super.method.call(this, ...args)`
✅ Deploy Preview for stylus-docs canceled.
|
|
Hi. I'm not sure how to approach this. It would be a good idea to add a test case for the regression, but it might be a better idea to add a test case that checks the How can I approach this? |
iChenLei
added a commit
that referenced
this pull request
Nov 11, 2023
|
closed via #2843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fixes super calls like
super.method.call(this, ...args)by replacing them with direct super calls likesuper.method(...args)Why:
I did this change to avoid the
.callpattern.It also fixes #2820 which is a regression caused by the Classes PR (#2813) where code was transformed incorrectly on my part, which I apologise for.
The code before the PR was:
and the code was incorrectly transformed into
when it should have instead been
Checklist: