Fixed interruption of Auto Build by RefreshStatusCacheSchedulingRule #70
Conversation
Referring to the discussion (https://groups.google.com/forum/#!topic/subclipse/Ntbl_SfxUrg) a fix is provided to avoid the interruption of the auto build process by the RefreshStatusCacheSchedulingRule. By falling back to a MultiRule, the auto build is finished before the status cache refresh is triggered. Signed-off-by: HBuender <hendrik.buender@googlemail.com>
|
@markphip any chance you could have a look? |
|
Isn't the solution to this problem to wrap the process that modifies a lot of files in the Workspace in a WorkspaceModifyOperation so that the "Refresh SVN status cache" job will only be triggered once, at the end? |
| @@ -315,15 +315,15 @@ public void propertyChange(PropertyChangeEvent event) { | |||
| ignoreManagedDerivedResources = SVNProviderPlugin.getPlugin().getPluginPreferences().getBoolean(ISVNCoreConstants.PREF_IGNORE_MANAGED_DERIVED_RESOURCES); | |||
| } | |||
| } | |||
|
|
|||
| private class RefreshStatusCacheSchedulingRule implements ISchedulingRule { | |||
There was a problem hiding this comment.
If we do go back to using MultiRule then we should remove the private RefreshStatusCacheSchedulingRule class, as it will be no longer used.
| @@ -197,7 +197,7 @@ public void run() { | |||
| SVNProviderPlugin.broadcastModificationStateChanges(resources); | |||
| } | |||
| } | |||
| }, new RefreshStatusCacheSchedulingRule(MultiRule.combine(projectArray)), false); | |||
There was a problem hiding this comment.
This change is basically undoing the 1a8bed9 change, which was made so that it would still be possible to save file changes in a project while a long running status cache update was going on. IMO, this fix needs to be done in a way that does not lose that functionality.
When scheduling status cache refresh job use a scheduling rule that prevents
other status cache refresh jobs from running at the same time for the same
project (for example, if some tool is making changes in the workspace without
wrapping the changes in a WorkspaceModifyOperation), but does not lock the
project (i.e., does not prevent saving project changes).
|
Note that the 4.3.0 release includes a different approach to this by introducing a preference to toggle off this status refresh. Perhaps that will be the solution to use since it seems like there are otherwise conflicting requirements here. |
|
I will take a look into the potential of the new feature within the next days. Thanks for your support |
Referring to the discussion
(https://groups.google.com/forum/#!topic/subclipse/Ntbl_SfxUrg) a fix is
provided to avoid the interruption of the auto build process by the
RefreshStatusCacheSchedulingRule.
By falling back to a MultiRule, the auto build is finished before the
status cache refresh is triggered.
Signed-off-by: HBuender hendrik.buender@googlemail.com