-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ruby]Add new BlankSlate
snippet using BasicObject
#3425
base: master
Are you sure you want to change the base?
[Ruby]Add new BlankSlate
snippet using BasicObject
#3425
Conversation
How about just not using that snippet? Removed things tend to cause someone to complain for whatever reason. Just imagine maintainer of old code bases maybe relying on older ruby builds for some reason, which still might want that snippet. |
The linked page from above says that extended maintenance for v1.9.3 ended in 2015, so I guess he has a point. |
I have this Erlang conversation in mind when it comes to supporting legacy stuff. So if we don't remove keywords from a language, which have been deprecated since 2007, why should we remove things, which only date back to 2015? The point is: There are probably dozens of out dated snippets like that. No one revized snippets for years. Removing one snippet doesn't change things nor does is it "much simpler". It's rather minor or even negligible. |
Right. I'm saying both your points are valid. |
@deathaxe thanks for your feedback :)
Yes, that was my concern.
I'm willing to do that, but I have another suggestion for this, I'd like to assign another trigger for How about adding |
Just in case you didn't know:
|
That's good to know! I'm lazy, so it'll be great if nice snippets are available by default rather than customizing. 😸 |
Looks like a reasonable change / trigger. |
e9f9ce6
to
6f6fd6d
Compare
- Use BasicObject for Ruby BlankSlate since `BasicObject` is available as of Ruby v1.9[^1]. - Change tabTrigger from `cla` to `clab` since we already have some snippets triggered by `cla` - Simplify snippet file name [^1]: https://ruby-doc.org/core-1.9.3/BasicObject.html
6f6fd6d
to
65b13ae
Compare
@deathaxe Hey, I've re-added Ruby BlankSlate snippets. Could you review it ❓ |
BlankSlate
snippet using BasicObject
I hesitate approving this change because snippet's content is significantly changed. Changing trigger to reduce duplicates might be ok, but I am not sure whether changed content may cause complains. |
I don't think so. I know many people are still using Ruby v2.x, but I don't know people still using Ruby v1.9 in 2023. |
Description
Since Ruby 1.9,
BasicObject
is available to createBlankSlate
class.ref. https://ruby-doc.org/core-1.9.3/BasicObject.html
I re-create BlankSlate snippet and modify
tabTrigger
in order to distinguish from other Ruby class snippets.Changes
BasicObject
is available as of Ruby v1.9cla
toclab
since we already have some snippets triggered bycla
BlankSlate
ExampleThe following is an example of
BlankSlate
class withBasicObject