Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sublime] Add Syntax Test Results syntax #3931

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

deathaxe
Copy link
Collaborator

This PR proposes to add a Sublime package with Sublime Syntax Test Results syntax definition for highlighting syntax test result outputs with regards to sublimehq/sublime_text#3022.

Thoughts:

  1. A package named "Sublime" does not yet exist on package control.
  2. The package name is generic enough to potentially take more Sublime Text related syntax files.

Maybe more suitable alternative package names are appriciated.

Syntax definition is designed to highlight ST's default syntax test result output - despite the proposal in sublimehq/sublime_text#3022, which addresses a reformatted output.

grafik

This commit adds a "Sublime" package with "Sublime Syntax Test Results"
syntax definition for highlighting syntax test result outputs.
This commit adds patterns to scope operators and groups, but without addressing
invalid syntax, because those are ignored and thus not printed to results panel.
@FichteFoll
Copy link
Collaborator

FichteFoll commented Feb 24, 2024

I am definitely in favor of also reformatting the line display like in sublimehq/sublime_text#3022 (comment) because it is much easier to compare the expected selector and actual scope that way.

@michaelblyons
Copy link
Collaborator

  1. The package name is generic enough to potentially take more Sublime Text related syntax files.

Are you thinking of moving the file patterns? That makes sense to me if this folder is added.

@deathaxe
Copy link
Collaborator Author

I didn't have certain syntaxes in mind - just found adding a package named Sublime Syntax Test Results with only one file/syntax inside rather too specific.

Not sure, what a good name for such ST related syntaxes would be.

Depending on how packages are finally built by sublimehq, I could also imagine creating a "Default" package in this repo. It however would require containing files to be added to "Default.sublime-package". Not sure if that's desirable.

@FichteFoll
Copy link
Collaborator

FichteFoll commented Feb 25, 2024

I would also guess that the Default package makes sense as a holder of various built-in functionality and as something that cannot/should not be disabled because it is referenced in other built-in parts. Iirc there used to be problems for people that disabled the package with the regular expression syntax for some reason, for example.

However, it raises the question of whether it can/should be included inside of this repo in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants