Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for few volar debugging commands #192

Merged
merged 11 commits into from Jul 3, 2023
Merged

feat: add support for few volar debugging commands #192

merged 11 commits into from Jul 3, 2023

Conversation

rchl
Copy link
Member

@rchl rchl commented Jul 2, 2023 •
edited

Some commands that help with debugging Vue type issues.

The volar/server/showReferences handler is removed as it's not longer supported by Volar this way (think it uses some LSP standard stuff now).

@rchl
Copy link
Member Author

rchl commented Jul 2, 2023

The volar/server/showReferences handler is removed as it's not longer supported by Volar this way (think it uses some LSP standard stuff now).

Actually Volar now uses non-standard editor.action.showReferences command. I will update the code.

predragnikolic
predragnikolic approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@predragnikolic predragnikolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks cool!

Do you think that it is good to add the commands to the README?

predrag-codetribe
predrag-codetribe reviewed Jul 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@rchl rchl merged commit 70ccf1c into master Jul 3, 2023
@rchl rchl deleted the feat/debug-commands branch July 3, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@predrag-codetribe predrag-codetribe predrag-codetribe left review comments

@predragnikolic predragnikolic predragnikolic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rchl @predragnikolic @predrag-codetribe