Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from stale app to stale GHA #2802

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Switch from stale app to stale GHA #2802

merged 1 commit into from
Nov 17, 2023

Conversation

dfarrell07
Copy link
Member

The stale app has been deprecated and replaced with a GitHub Action.

probot/probot.github.io#376
probot/stale#385

@dfarrell07 dfarrell07 self-assigned this Nov 15, 2023
@submariner-bot
Copy link
Contributor

🤖 Created branch: z_pr2802/dfarrell07/stale_gha
🚀 Full E2E won't run until the "ready-to-test" label is applied. I will add it automatically once the PR has 2 approvals, or you can add it manually.

skitt
skitt approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@skitt skitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for other reviewers: this uses the default delay before closing stale issues/PRs, 7 days.

@dfarrell07
Copy link
Member Author

Note for other reviewers: this uses the default delay before closing stale issues/PRs, 7 days.

Right, which is the same we had manually configured before.

@submariner-bot submariner-bot added the ready-to-test When a PR is ready for full E2E testing label Nov 16, 2023
tpantelis
tpantelis reviewed Nov 16, 2023
View reviewed changes
.github/workflows/stale.yml
days-before-pr-stale: 14
exempt-issue-labels: 'confirmed,security'
exempt-pr-labels: 'confirmed,security'
stale-issue-label: 'stale'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use wontfix as before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can choose. Thought "stale" made more sense, was a more accurate description.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create "stale" labels as I send these changes to repos. Already created one for this repo. I'll also update the scrub filter accordingly. We can clear the old "wolntfix" ones during the next scrub calls.

@dfarrell07
Switch from stale app to stale GHA
30670aa 
The stale app has been deprecated and replaced with a GitHub Action.

probot/probot.github.io#376
probot/stale#385

Signed-off-by: Daniel Farrell <dfarrell@redhat.com>
@tpantelis tpantelis merged commit 50a7f9e into submariner-io:devel Nov 17, 2023
36 of 37 checks passed
@submariner-bot
Copy link
Contributor

🤖 Closed branches: [z_pr2802/dfarrell07/stale_gha]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skitt skitt skitt approved these changes

@sridhargaddam sridhargaddam sridhargaddam approved these changes

@tpantelis tpantelis tpantelis approved these changes

@mkolesnik mkolesnik Awaiting requested review from mkolesnik mkolesnik is a code owner

@Oats87 Oats87 Awaiting requested review from Oats87 Oats87 is a code owner

Assignees

@dfarrell07 dfarrell07

Labels
automation ready-to-test When a PR is ready for full E2E testing
Projects
No open projects
Submariner 0.17
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dfarrell07 @submariner-bot @skitt @sridhargaddam @tpantelis