-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sat): telemetry support and startup / shutdown cleanup #56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments. One thing I'm not seeing is the tracer being used anywhere. I would have expected it to be mounted on Sat's Vektor router and also some manual tracing being added to handleFnResult
in meshed.go. Is that coming in another PR?
@cohix I've added tracing code to both the vektor end of things, and the grav end of things. The code assumes that the handler func in And it also assumes that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After 58 is fixed up and merged, this is good to go! Well done.
* Add branching at startup for stdin / service modes * Let's not do double work if not needed :D
Closes #54