Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitor service #2402

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Monitor service #2402

wants to merge 20 commits into from

Conversation

jiqiang90
Copy link
Member

@jiqiang90 jiqiang90 commented May 14, 2024 •
edited

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

TODO:

  • add service to other place ,and write data
  • ideally this should add from main threat, but we need handle workers with this service
  • part of Admin api

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited

Coverage report for .

Caution

Test run failed

St.❔
 Category Percentage Covered / Total
🟡 Statements
62.62% (-7.49% 🔻)
 17868/28536
🟡 Branches
78.71% (+0.42% 🔼)
 2248/2856
🟡 Functions
64.48% (+1.98% 🔼)
 995/1543
🟡 Lines
62.62% (-7.49% 🔻)
 17868/28536
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / migrate.ts
 85.09% 18.18% 100% 85.09%
🟢
... / migrate-abis.controller.ts
 95% 87.5% 100% 95%
🟢
... / constants.ts
 100% 100% 100% 100%
🟢
... / index.ts
 100% 100% 100% 100%
🟢
... / ethereum.ts
 82.05% 83.33% 100% 82.05%
🟢
... / migrate-manifest.controller.ts
 88% 73.33% 88.89% 88%
🟢
... / migrate-mapping.controller.ts
 100% 100% 100% 100%
🟢
... / migrate-controller.ts
 92.31% 84.62% 100% 92.31%
🟢
... / migrate.fixtures.ts
 100% 100% 100% 100%
🟢
... / migrate-schema.controller.ts
 100% 100% 100% 100%
🔴
... / types.ts
 0% 0% 0% 0%
🟢
... / createProject.fixtures.ts
 90.16% 66.67% 100% 90.16%
🟢
... / networkFamily.ts
 92.59% 88.89% 100% 92.59%
🔴
... / admin.controller.ts
 0% 0% 0% 0%
🟢
... / blockRange.ts
 100% 100% 100% 100%
🔴
... / index.ts
 0% 0% 0% 0%
🟢
... / dictionary.fixtures.ts
 100% 100% 100% 100%
🟡
... / monitor.service.ts
 65.43% 84.42% 93.94% 65.43%
🔴
... / sandbox.service.ts
 33.33% 50% 25% 33.33%
🔴
... / worker.monitor.service.ts
 41.46% 100% 0% 41.46%
🔴
... / process.ts
 50% 66.67% 40% 50%
🔴
... / foreceClean.init.ts
 47.62% 100% 0% 47.62%
🔴
... / reindex.init.ts
 34.48% 100% 0% 34.48%
🟢
... / string.ts
 100% 100% 100% 100%
🔴
... / admin.module.ts
 0% 0% 0% 0%
🔴
... / datasourceProcessors.ts
 0% 0% 0% 0%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🔴
... / index.ts
26.14% (-56.82% 🔻)
100% (+33.33% 🔼)
 50%
26.14% (-56.82% 🔻)
🔴
... / index.ts
33.87% (-58.06% 🔻)
100% (+75% 🔼)
50% (-50% 🔻)
33.87% (-58.06% 🔻)
🔴
... / deploy.ts
18.97% (-2.17% 🔻)
 100%
50% (+50% 🔼)
18.97% (-2.17% 🔻)
🔴
... / publish.ts
28% (-61.33% 🔻)
100% (+42.86% 🔼)
50% (-50% 🔻)
28% (-61.33% 🔻)
🔴
... / build-controller.ts
11.96% (-79.35% 🔻)
100% (+42.86% 🔼)
0% (-100% 🔻)
11.96% (-79.35% 🔻)
🟢
... / codegen-controller.ts
 89.39%
75% (-0.58% 🔻)
 100% 89.39%
🟢
... / generate-controller.ts
 97.65%
93.85% (-0.18% 🔻)
 100% 97.65%
🟡
... / init-controller.ts
76.73% (+6.24% 🔼)
67.65% (-0.35% 🔻)
61.11% (+7.78% 🔼)
76.73% (+6.24% 🔼)
🔴
... / publish-controller.ts
14.81% (-65.43% 🔻)
100% (+28.89% 🔼)
0% (-100% 🔻)
14.81% (-65.43% 🔻)
🟢 cli/src/types.ts
96.97% (-0.03% 🔻)
 100% 33.33%
96.97% (-0.03% 🔻)
🟡
... / build.ts
74.48% (-10.34% 🔻)
80% (+3.08% 🔼)
87.5% (-12.5% 🔻)
74.48% (-10.34% 🔻)
🟡
... / utils.ts
79.61% (-1.48% 🔻)
88.14% (+7.43% 🔼)
78.57% (+1.3% 🔼)
79.61% (-1.48% 🔻)
🔴
... / models.ts
30% (-69.44% 🔻)
75% (-17.31% 🔻)
0% (-100% 🔻)
30% (-69.44% 🔻)
🔴
... / ProjectManifestVersioned.ts
47.95% (-36.99% 🔻)
87.5% (-12.5% 🔻)
53.85% (-4.49% 🔻)
47.95% (-36.99% 🔻)
🔴
... / model.ts
28.57% (-69.14% 🔻)
89.47% (-10.53% 🔻)
33.33% (-38.1% 🔻)
28.57% (-69.14% 🔻)
🔴
... / models.ts
47.06% (-52.94% 🔻)
 100%
0% (-100% 🔻)
47.06% (-52.94% 🔻)
🔴
... / load.ts
54.08% (-5.1% 🔻)
56.25% (+0.69% 🔼)
50% (-16.67% 🔻)
54.08% (-5.1% 🔻)
🟡
... / github-reader.ts
60.71% (-28.57% 🔻)
 75%
71.43% (-11.9% 🔻)
60.71% (-28.57% 🔻)
🟡
... / ipfs-reader.ts
63.49% (-22.22% 🔻)
83.33% (+19.7% 🔼)
71.43% (-11.9% 🔻)
63.49% (-22.22% 🔻)
🟡
... / local-reader.ts
60.47% (-25.58% 🔻)
 62.5%
83.33% (-16.67% 🔻)
60.47% (-25.58% 🔻)
🔴
... / utils.ts
50% (-12.7% 🔻)
87.5% (+14.33% 🔼)
48% (-8% 🔻)
50% (-12.7% 🔻)
🔴
... / base.ts
44% (-54% 🔻)
 100%
40% (-40% 🔻)
44% (-54% 🔻)
🔴
... / models.ts
25.32% (-74.68% 🔻)
 100%
0% (-100% 🔻)
25.32% (-74.68% 🔻)
🟡
... / api.connection.error.ts
65.45% (-3.43% 🔻)
 100%
16.67% (+16.67% 🔼)
65.45% (-3.43% 🔻)
🟢
... / NodeConfig.ts
87.95% (-0.66% 🔻)
77.19% (-2.44% 🔻)
86.96% (+0.91% 🔼)
87.95% (-0.66% 🔻)
🟡
... / ProjectUpgrade.service.ts
72.33% (-14.74% 🔻)
87.5% (-3.86% 🔻)
84% (-7.3% 🔻)
72.33% (-14.74% 🔻)
🟢
... / db.module.ts
89.06% (+0.78% 🔼)
62.5% (-20.83% 🔻)
 80%
89.06% (+0.78% 🔼)
🟡
... / migration-helpers.ts
75.28% (-0.74% 🔻)
88.24% (+7.64% 🔼)
 90.91%
75.28% (-0.74% 🔻)
🟡
... / sequelizeUtil.ts
79.46% (-11.61% 🔻)
65.38% (-4.99% 🔻)
 62.5%
79.46% (-11.61% 🔻)
🟡
... / StoreOperations.ts
72.94% (-19.37% 🔻)
86.36% (+1.36% 🔼)
87.5% (-12.5% 🔻)
72.94% (-19.37% 🔻)
🔴
... / benchmark.service.ts
43.36% (-11.89% 🔻)
 66.67%
36.36% (-3.64% 🔻)
43.36% (-11.89% 🔻)
🔴
... / base-block-dispatcher.ts
19% (-28.35% 🔻)
 100%
4.35% (-5.65% 🔻)
19% (-28.35% 🔻)
🔴
... / block-dispatcher.ts
26.98% (-14.01% 🔻)
 66.67%
25% (-3.57% 🔻)
26.98% (-14.01% 🔻)
🔴
... / worker-block-dispatcher.ts
36.17% (-14.04% 🔻)
 100%
25% (-2.27% 🔻)
36.17% (-14.04% 🔻)
🔴
... / coreDictionary.ts
45.33% (-54.67% 🔻)
87.5% (-6.94% 🔻)
77.78% (-22.22% 🔻)
45.33% (-54.67% 🔻)
🟡
... / dictionary.service.ts
67.01% (-18.14% 🔻)
82.35% (-3.36% 🔻)
83.33% (-7.58% 🔻)
67.01% (-18.14% 🔻)
🟡
... / dictionaryV1.ts
75.1% (-18.13% 🔻)
76.09% (-2.17% 🔻)
91.67% (-8.33% 🔻)
75.1% (-18.13% 🔻)
🟡
... / dictionaryV2.ts
67.37% (-14.31% 🔻)
68% (+2.78% 🔼)
88.89% (-11.11% 🔻)
67.37% (-14.31% 🔻)
🔴
... / ds-processor.service.ts
39.37% (-22.72% 🔻)
 75%
58.33% (-29.17% 🔻)
39.37% (-22.72% 🔻)
🔴
... / dynamic-ds.service.ts
59.84% (-30.35% 🔻)
65% (-1.67% 🔻)
80% (-5.71% 🔻)
59.84% (-30.35% 🔻)
🟢
... / inMemoryCache.service.ts
86.21% (-13.79% 🔻)
 100%
75% (-25% 🔻)
86.21% (-13.79% 🔻)
🔴
... / indexer.manager.ts
16.13% (-17.08% 🔻)
 100%
10% (-2.5% 🔻)
16.13% (-17.08% 🔻)
🟢
... / PoiBlock.ts
83.87% (-14.52% 🔻)
 96.55%
75% (-25% 🔻)
83.87% (-14.52% 🔻)
🔴
... / poi.service.ts
12.39% (-11.53% 🔻)
 100%
20% (-8.57% 🔻)
12.39% (-11.53% 🔻)
🔴
... / poiModel.ts
40% (-23.64% 🔻)
 71.43%
44.44% (-12.7% 🔻)
40% (-23.64% 🔻)
🔴
... / poiSync.service.ts
55.88% (-31% 🔻)
77.61% (+1.05% 🔼)
88.89% (-3.42% 🔻)
55.88% (-31% 🔻)
🟡
... / project.service.ts
66.1% (-13.9% 🔻)
69.64% (-0.53% 🔻)
80.77% (-3.23% 🔻)
66.1% (-13.9% 🔻)
🟡
... / sandbox.ts
60.49% (-7.49% 🔻)
60% (+2.86% 🔼)
57.14% (-4.4% 🔻)
60.49% (-7.49% 🔻)
🔴
... / smartBatch.service.ts
10.43% (-13.91% 🔻)
 100%
12.5% (-1.79% 🔻)
10.43% (-13.91% 🔻)
🟡
... / store.service.ts
65.91% (-0.14% 🔻)
66.67% (-1.75% 🔻)
58.62% (+1.48% 🔼)
65.91% (-0.14% 🔻)
🔴
... / entity.ts
19.23% (-42.31% 🔻)
 100% 0%
19.23% (-42.31% 🔻)
🔴
... / store.ts
13.11% (-19.09% 🔻)
 100% 0%
13.11% (-19.09% 🔻)
🟡
... / cacheModel.ts
70.98% (-14.09% 🔻)
84.93% (+6.62% 🔼)
71.43% (-4.76% 🔻)
70.98% (-14.09% 🔻)
🟡
... / cachePoi.ts
75.53% (-18.09% 🔻)
 88.89%
71.43% (-11.9% 🔻)
75.53% (-18.09% 🔻)
🟢
... / cacheable.ts
89.66% (-0.97% 🔻)
 75% 100%
89.66% (-0.97% 🔻)
🟡
... / csvStore.service.ts
76.92% (-14.1% 🔻)
 80%
80% (-20% 🔻)
76.92% (-14.1% 🔻)
🔴
... / setValueModel.ts
56.41% (-25.6% 🔻)
75.76% (-5.49% 🔻)
78.57% (-6.04% 🔻)
56.41% (-25.6% 🔻)
🟢
... / test.runner.ts
94.67% (-4.67% 🔻)
 73.33%
66.67% (-33.33% 🔻)
94.67% (-4.67% 🔻)
🔴
... / testing.service.ts
12% (-16.57% 🔻)
 100% 0%
12% (-16.57% 🔻)
🟡
... / unfinalizedBlocks.service.ts
63.19% (-20.79% 🔻)
 96.72%
88% (-3.67% 🔻)
63.19% (-20.79% 🔻)
🔴
... / worker.builder.ts
59.83% (-19.36% 🔻)
 65.38% 80%
59.83% (-19.36% 🔻)
🔴
... / worker.cache.service.ts
48.78% (-9.76% 🔻)
 100% 0%
48.78% (-9.76% 🔻)
🔴
... / worker.connectionPoolState.manager.ts
38.21% (-22.76% 🔻)
 100% 0%
38.21% (-22.76% 🔻)
🔴
... / worker.dynamic-ds.service.ts
44.44% (-17.78% 🔻)
 100% 0%
44.44% (-17.78% 🔻)
🔴
... / worker.service.ts
20.35% (-24.29% 🔻)
 100% 0%
20.35% (-24.29% 🔻)
🟢
... / worker.store.service.ts
80% (-2.61% 🔻)
 100% 50%
80% (-2.61% 🔻)
🔴
... / worker.ts
41.82% (-0.63% 🔻)
 100% 0%
41.82% (-0.63% 🔻)
🔴
... / worker.unfinalizedBlocks.service.ts
33.33% (-66.67% 🔻)
 100%
0% (-100% 🔻)
33.33% (-66.67% 🔻)
🔴
... / logger.ts
44.74% (-19.74% 🔻)
 33.33%
40% (+20% 🔼)
44.74% (-19.74% 🔻)
🟡
... / meta.service.ts
68.57% (-0.95% 🔻)
100% (+20% 🔼)
36.36% (-3.64% 🔻)
68.57% (-0.95% 🔻)
🔴
... / forceClean.service.ts
22.08% (-4.24% 🔻)
 100% 0%
22.08% (-4.24% 🔻)
🔴
... / reindex.service.ts
14.73% (-18.6% 🔻)
 100% 0%
14.73% (-18.6% 🔻)
🟡
... / autoQueue.ts
60.3% (-28.09% 🔻)
 85.11%
73.08% (-6.09% 🔻)
60.3% (-28.09% 🔻)
🟡
... / blocks.ts
77.78% (-22.22% 🔻)
 88.89%
66.67% (-33.33% 🔻)
77.78% (-22.22% 🔻)
🟡
... / project.ts
67.11% (-6.27% 🔻)
58.49% (-16.09% 🔻)
 77.78%
67.11% (-6.27% 🔻)
🟢
... / promise.ts
86.44% (-5.32% 🔻)
100% (+13.64% 🔼)
71.43% (-14.29% 🔻)
86.44% (-5.32% 🔻)
🔴
... / yargs.ts
44.38% (-1.11% 🔻)
 100% 14.29%
44.38% (-1.11% 🔻)
🟢
... / SubqueryProject.ts
93.33% (-2.19% 🔻)
46.67% (-35.69% 🔻)
87.5% (+1.79% 🔼)
93.33% (-2.19% 🔻)
🟡
... / apiPromise.connection.ts
67.36% (-1.72% 🔻)
 80%
50% (+7.14% 🔼)
67.36% (-1.72% 🔻)
🔴
... / worker-block-dispatcher.service.ts
24.64% (-12.32% 🔻)
 100% 0%
24.64% (-12.32% 🔻)
🟢
... / substrateDictionary.service.ts
93.2% (+2.64% 🔼)
41.67% (-31.06% 🔻)
100% (+20% 🔼)
93.2% (+2.64% 🔼)
🟢
... / substrateDictionaryV1.ts
80.07% (-5.42% 🔻)
 69.77%
76.92% (-6.41% 🔻)
80.07% (-5.42% 🔻)
🟡
... / substrateDictionaryV2.ts
70.79% (-4.72% 🔻)
50% (-25% 🔻)
 33.33%
70.79% (-4.72% 🔻)
🟢
... / fetch.module.ts
90% (-1.88% 🔻)
50% (-25% 🔻)
 100%
90% (-1.88% 🔻)
🔴
... / indexer.manager.ts
56.35% (-1.2% 🔻)
 100%
20% (+10.91% 🔼)
56.35% (-1.2% 🔻)
🟢
... / runtimeService.ts
94.29% (+2.08% 🔼)
81.82% (-7.07% 🔻)
100% (+20% 🔼)
94.29% (+2.08% 🔼)
🔴
... / http.ts
49.03% (-30.89% 🔻)
 40%
28.57% (-2.2% 🔻)
49.03% (-30.89% 🔻)
🟢
... / project.ts
88.81% (-0.08% 🔻)
 68.18% 87.5%
88.81% (-0.08% 🔻)
🟢
... / buffer.ts
95.12% (-4.88% 🔻)
95.65% (-4.35% 🔻)
85.71% (+1.5% 🔼)
95.12% (-4.88% 🔻)
🟢
... / entities.ts
87.77% (-0.54% 🔻)
84.4% (-1.68% 🔻)
 100%
87.77% (-0.54% 🔻)
🟡
... / logger.ts
70.2% (+0.6% 🔼)
54.55% (-0.45% 🔻)
76.92% (+1.92% 🔼)
70.2% (+0.6% 🔼)

Test suite run failed

Failed tests: 15/516. Failed suites: 9/98. 
  ● CLI codegen:generate › extract from TS manifest

    expect(received).toMatch(expected)

    Expected substring: "approve(address spender, uint256 rawAmount)"
    Received string:    "0x095ea7b3"

      684 |     );
      685 |     // TODO expected to fail, due to unable to skip comments
    > 686 |     expect(v.function).toMatch('approve(address spender, uint256 rawAmount)');
          |                        ^
      687 |     expect(v.topics[0]).toMatch('Transfer(address indexed from, address indexed to, uint256 amount)');
      688 |     expect(v.endpoint[0]).toMatch('https://eth.api.onfinality.io/public');
      689 |   });

      at Object.<anonymous> (packages/cli/src/controller/generate-controller.spec.ts:686:24)


  ● cacheModel › without historical › can avoid race conditions

    Entity should exist

      122 |       const entity1 = await testModel.get('entity1_id_0x01');
      123 |       if (!entity1) {
    > 124 |         throw new Error('Entity should exist');
          |               ^
      125 |       }
      126 |
      127 |       // updated height to 2

      at Object.<anonymous> (packages/node-core/src/indexer/storeCache/cacheModel.spec.ts:124:15)


  ● Test suite failed to run

    Your test suite must contain at least one test.

      at onResult (node_modules/@jest/core/build/TestScheduler.js:133:18)
      at node_modules/@jest/core/build/TestScheduler.js:254:19
      at node_modules/emittery/index.js:363:13
          at Array.map (<anonymous>)
      at Emittery.emit (node_modules/emittery/index.js:361:23)


  ● Cli can create project (mocked) › Ensure prepareManifest and preparePackage correctness for project.ts

    expect(received).toStrictEqual(expected) // deep equality

    Expected: ["https://zzz", "https://bbb"]
    Received: null

      190 |       endpoint: ENDPOINT_REG,
      191 |     });
    > 192 |     expect(extractedValues.endpoint).toStrictEqual(project.endpoint);
          |                                      ^
      193 |     expect(originalManifest).not.toBe(updatedManifest.toString());
      194 |     expect(originalPackage).not.toBe(packageData.toString());
      195 |   });

      at Object.<anonymous> (packages/cli/src/controller/init-controller.spec.ts:192:38)


  ● Test suite failed to run

    Jest worker encountered 4 child process exceptions, exceeding retry limit

      at ChildProcessWorker.initialize (node_modules/jest-worker/build/workers/ChildProcessWorker.js:181:21)


  ● CLI deploy, delete, promote › Deploy to Hosted Service and Delete

    Failed to validate IPFS CID: Unauthorized

      88 | export function errorHandle(e: any, msg: string): Error {
      89 |   if (axios.isAxiosError(e) && e?.response?.data) {
    > 90 |     throw new Error(`${msg} ${e.response.data.message ?? e.response.data}`);
         |           ^
      91 |   }
      92 |
      93 |   throw new Error(`${msg} ${e.message}`);

      at errorHandle (packages/cli/src/utils/utils.ts:90:11)
      at ipfsCID_validate (packages/cli/src/controller/deploy-controller.ts:169:16)
      at Object.<anonymous> (packages/cli/src/controller/deploy-controller.spec.ts:110:23)

  ● CLI deploy, delete, promote › should return true for valid ipfsCID

    Failed to validate IPFS CID: Unauthorized

      88 | export function errorHandle(e: any, msg: string): Error {
      89 |   if (axios.isAxiosError(e) && e?.response?.data) {
    > 90 |     throw new Error(`${msg} ${e.response.data.message ?? e.response.data}`);
         |           ^
      91 |   }
      92 |
      93 |   throw new Error(`${msg} ${e.message}`);

      at errorHandle (packages/cli/src/utils/utils.ts:90:11)
      at ipfsCID_validate (packages/cli/src/controller/deploy-controller.ts:169:16)
      at Object.<anonymous> (packages/cli/src/controller/deploy-controller.spec.ts:139:23)

  ● CLI deploy, delete, promote › to throw error for invalid ipfsCID

    expect(received).rejects.toThrow(expected)

    Expected substring: "Failed to validate IPFS CID: fake is not a valid subquery deployment id!"
    Received message:   "Failed to validate IPFS CID: Unauthorized"

          88 | export function errorHandle(e: any, msg: string): Error {
          89 |   if (axios.isAxiosError(e) && e?.response?.data) {
        > 90 |     throw new Error(`${msg} ${e.response.data.message ?? e.response.data}`);
             |           ^
          91 |   }
          92 |
          93 |   throw new Error(`${msg} ${e.message}`);

      at errorHandle (packages/cli/src/utils/utils.ts:90:11)
      at ipfsCID_validate (packages/cli/src/controller/deploy-controller.ts:169:16)
      at Object.<anonymous> (packages/cli/src/controller/deploy-controller.spec.ts:144:5)
      at Object.toThrow (node_modules/expect/build/index.js:210:22)
      at Object.<anonymous> (packages/cli/src/controller/deploy-controller.spec.ts:144:80)

  ● CLI deploy, delete, promote › get DictEndpoint - polkadot

    Failed to validate IPFS CID: Unauthorized

      88 | export function errorHandle(e: any, msg: string): Error {
      89 |   if (axios.isAxiosError(e) && e?.response?.data) {
    > 90 |     throw new Error(`${msg} ${e.response.data.message ?? e.response.data}`);
         |           ^
      91 |   }
      92 |
      93 |   throw new Error(`${msg} ${e.message}`);

      at errorHandle (packages/cli/src/utils/utils.ts:90:11)
      at ipfsCID_validate (packages/cli/src/controller/deploy-controller.ts:169:16)
      at Object.<anonymous> (packages/cli/src/controller/deploy-controller.spec.ts:150:23)

  ● CLI deploy, delete, promote › reDeploy to Hosted Service

    Failed to validate IPFS CID: Unauthorized

      88 | export function errorHandle(e: any, msg: string): Error {
      89 |   if (axios.isAxiosError(e) && e?.response?.data) {
    > 90 |     throw new Error(`${msg} ${e.response.data.message ?? e.response.data}`);
         |           ^
      91 |   }
      92 |
      93 |   throw new Error(`${msg} ${e.message}`);

      at errorHandle (packages/cli/src/utils/utils.ts:90:11)
      at ipfsCID_validate (packages/cli/src/controller/deploy-controller.ts:169:16)
      at Object.<anonymous> (packages/cli/src/controller/deploy-controller.spec.ts:160:23)


  ● Cli can create project › prepare correctly applies project details

    expect(received).toEqual(expected) // deep equality

    Expected: null
    Received: ["wss://rpc.polkadot.io/public-ws"]

      128 |     //spec version is  not returned from readDefaults
      129 |     //expect(projectSpec.specVersion).toEqual(specVersion);
    > 130 |     expect(projectSpec.endpoint).toEqual(endpoint);
          |                                  ^
      131 |     expect(projectSpec.author).toEqual(author);
      132 |     expect(projectSpec.description).toEqual(description);
      133 |     await promisify(rimraf)(tempPath);

      at Object.<anonymous> (packages/cli/src/controller/init-controller.test.ts:130:34)


  ● Cli publish › should upload appropriate project to IPFS

    Command failed: npm i
    npm error code ERESOLVE
    npm error ERESOLVE unable to resolve dependency tree
    npm error
    npm error While resolving: mocked_starter@1.0.0
    npm error Found: @polkadot/api@10.13.1
    npm error node_modules/@polkadot/api
    npm error   dev @polkadot/api@"^10" from the root project
    npm error
    npm error Could not resolve dependency:
    npm error peer @polkadot/api@"^11" from @subql/types@3.6.0
    npm error node_modules/@subql/types
    npm error   dev @subql/types@"latest" from the root project
    npm error
    npm error Fix the upstream dependency conflict, or retry
    npm error this command with --force or --legacy-peer-deps
    npm error to accept an incorrect (and potentially broken) dependency resolution.
    npm error
    npm error
    npm error For a full report see:
    npm error /home/runner/.npm/_logs/2024-05-31T01_58_50_999Z-eresolve-report.txt

    npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-05-31T01_58_50_999Z-debug-0.log

      53 |
      54 |   // Install dependencies
    > 55 |   childProcess.execSync(`npm i`, {cwd: projectDir});
         |                ^
      56 |
      57 |   await Codegen.run(['-l', projectDir]);
      58 |   await Build.run(['-f', projectDir]);

      at createTestProject (packages/cli/src/createProject.fixtures.ts:55:16)
      at Object.<anonymous> (packages/cli/src/controller/publish-controller.spec.ts:22:18)

  ● Cli publish › convert to deployment and removed descriptive field

    Command failed: npm i
    npm error code ERESOLVE
    npm error ERESOLVE unable to resolve dependency tree
    npm error
    npm error While resolving: mocked_starter@1.0.0
    npm error Found: @polkadot/api@10.13.1
    npm error node_modules/@polkadot/api
    npm error   dev @polkadot/api@"^10" from the root project
    npm error
    npm error Could not resolve dependency:
    npm error peer @polkadot/api@"^11" from @subql/types@3.6.0
    npm error node_modules/@subql/types
    npm error   dev @subql/types@"latest" from the root project
    npm error
    npm error Fix the upstream dependency conflict, or retry
    npm error this command with --force or --legacy-peer-deps
    npm error to accept an incorrect (and potentially broken) dependency resolution.
    npm error
    npm error
    npm error For a full report see:
    npm error /home/runner/.npm/_logs/2024-05-31T01_58_50_999Z-eresolve-report.txt

    npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-05-31T01_58_50_999Z-debug-0.log

      53 |
      54 |   // Install dependencies
    > 55 |   childProcess.execSync(`npm i`, {cwd: projectDir});
         |                ^
      56 |
      57 |   await Codegen.run(['-l', projectDir]);
      58 |   await Build.run(['-f', projectDir]);

      at createTestProject (packages/cli/src/createProject.fixtures.ts:55:16)
      at Object.<anonymous> (packages/cli/src/controller/publish-controller.spec.ts:22:18)

  ● Cli publish › convert js object to JSON object

    Command failed: npm i
    npm error code ERESOLVE
    npm error ERESOLVE unable to resolve dependency tree
    npm error
    npm error While resolving: mocked_starter@1.0.0
    npm error Found: @polkadot/api@10.13.1
    npm error node_modules/@polkadot/api
    npm error   dev @polkadot/api@"^10" from the root project
    npm error
    npm error Could not resolve dependency:
    npm error peer @polkadot/api@"^11" from @subql/types@3.6.0
    npm error node_modules/@subql/types
    npm error   dev @subql/types@"latest" from the root project
    npm error
    npm error Fix the upstream dependency conflict, or retry
    npm error this command with --force or --legacy-peer-deps
    npm error to accept an incorrect (and potentially broken) dependency resolution.
    npm error
    npm error
    npm error For a full report see:
    npm error /home/runner/.npm/_logs/2024-05-31T01_58_50_999Z-eresolve-report.txt

    npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-05-31T01_58_50_999Z-debug-0.log

      53 |
      54 |   // Install dependencies
    > 55 |   childProcess.execSync(`npm i`, {cwd: projectDir});
         |                ^
      56 |
      57 |   await Codegen.run(['-l', projectDir]);
      58 |   await Build.run(['-f', projectDir]);

      at createTestProject (packages/cli/src/createProject.fixtures.ts:55:16)
      at Object.<anonymous> (packages/cli/src/controller/publish-controller.spec.ts:22:18)


  ● Intergration test - Publish › overwrites any exisiting CID files

    Command failed: npm i
    npm error code ERESOLVE
    npm error ERESOLVE unable to resolve dependency tree
    npm error
    npm error While resolving: mocked_starter@1.0.0
    npm error Found: @polkadot/api@10.13.1
    npm error node_modules/@polkadot/api
    npm error   dev @polkadot/api@"^10" from the root project
    npm error
    npm error Could not resolve dependency:
    npm error peer @polkadot/api@"^11" from @subql/types@3.6.0
    npm error node_modules/@subql/types
    npm error   dev @subql/types@"latest" from the root project
    npm error
    npm error Fix the upstream dependency conflict, or retry
    npm error this command with --force or --legacy-peer-deps
    npm error to accept an incorrect (and potentially broken) dependency resolution.
    npm error
    npm error
    npm error For a full report see:
    npm error /home/runner/.npm/_logs/2024-05-31T01_59_04_926Z-eresolve-report.txt

    npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-05-31T01_59_04_926Z-debug-0.log

      53 |
      54 |   // Install dependencies
    > 55 |   childProcess.execSync(`npm i`, {cwd: projectDir});
         |                ^
      56 |
      57 |   await Codegen.run(['-l', projectDir]);
      58 |   await Build.run(['-f', projectDir]);

      at createTestProject (packages/cli/src/createProject.fixtures.ts:55:16)
      at Object.<anonymous> (packages/cli/src/commands/publish.test.ts:16:18)

  ● Intergration test - Publish › create ipfsCID file stored in local with dictiory path

    Command failed: npm i
    npm error code ERESOLVE
    npm error ERESOLVE unable to resolve dependency tree
    npm error
    npm error While resolving: mocked_starter@1.0.0
    npm error Found: @polkadot/api@10.13.1
    npm error node_modules/@polkadot/api
    npm error   dev @polkadot/api@"^10" from the root project
    npm error
    npm error Could not resolve dependency:
    npm error peer @polkadot/api@"^11" from @subql/types@3.6.0
    npm error node_modules/@subql/types
    npm error   dev @subql/types@"latest" from the root project
    npm error
    npm error Fix the upstream dependency conflict, or retry
    npm error this command with --force or --legacy-peer-deps
    npm error to accept an incorrect (and potentially broken) dependency resolution.
    npm error
    npm error
    npm error For a full report see:
    npm error /home/runner/.npm/_logs/2024-05-31T01_59_04_926Z-eresolve-report.txt

    npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-05-31T01_59_04_926Z-debug-0.log

      53 |
      54 |   // Install dependencies
    > 55 |   childProcess.execSync(`npm i`, {cwd: projectDir});
         |                ^
      56 |
      57 |   await Codegen.run(['-l', projectDir]);
      58 |   await Build.run(['-f', projectDir]);

      at createTestProject (packages/cli/src/createProject.fixtures.ts:55:16)
      at Object.<anonymous> (packages/cli/src/commands/publish.test.ts:16:18)

  ● Intergration test - Publish › file name consistent with manfiest file name, if -f <manifest path> is used

    Command failed: npm i
    npm error code ERESOLVE
    npm error ERESOLVE unable to resolve dependency tree
    npm error
    npm error While resolving: mocked_starter@1.0.0
    npm error Found: @polkadot/api@10.13.1
    npm error node_modules/@polkadot/api
    npm error   dev @polkadot/api@"^10" from the root project
    npm error
    npm error Could not resolve dependency:
    npm error peer @polkadot/api@"^11" from @subql/types@3.6.0
    npm error node_modules/@subql/types
    npm error   dev @subql/types@"latest" from the root project
    npm error
    npm error Fix the upstream dependency conflict, or retry
    npm error this command with --force or --legacy-peer-deps
    npm error to accept an incorrect (and potentially broken) dependency resolution.
    npm error
    npm error
    npm error For a full report see:
    npm error /home/runner/.npm/_logs/2024-05-31T01_59_04_926Z-eresolve-report.txt

    npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-05-31T01_59_04_926Z-debug-0.log

      53 |
      54 |   // Install dependencies
    > 55 |   childProcess.execSync(`npm i`, {cwd: projectDir});
         |                ^
      56 |
      57 |   await Codegen.run(['-l', projectDir]);
      58 |   await Build.run(['-f', projectDir]);

      at createTestProject (packages/cli/src/createProject.fixtures.ts:55:16)
      at Object.<anonymous> (packages/cli/src/commands/publish.test.ts:16:18)

Report generated by 🧪jest coverage report action from 28b2a0c

stwiname
stwiname reviewed May 14, 2024
View reviewed changes
packages/node-core/src/yargs.ts Show resolved Hide resolved
packages/node-core/src/indexer/monitor.service.ts Outdated Show resolved Hide resolved
packages/node-core/src/indexer/monitor.service.ts Outdated Show resolved Hide resolved
packages/node-core/src/indexer/monitor.service.ts Outdated Show resolved Hide resolved
packages/node-core/src/indexer/monitor.service.ts Show resolved Hide resolved
packages/node-core/src/indexer/monitor.service.ts Outdated Show resolved Hide resolved
stwiname
stwiname reviewed May 20, 2024
View reviewed changes
Copy link
Collaborator

@stwiname stwiname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions:

  • Make the montior service an optional dependency, this will clean up some tests
  • Another option to simplify integration, would be to use event emitter to write, to the monitor service, that way we don't need to inject the service everywhere

packages/node-core/src/utils/string.ts Show resolved Hide resolved
stwiname
stwiname reviewed May 20, 2024
View reviewed changes
Copy link
Collaborator

@stwiname stwiname left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to log the block hash being indexed.

packages/node-core/src/configure/ProjectUpgrade.service.spec.ts Outdated Show resolved Hide resolved
packages/node-core/src/indexer/blockDispatcher/block-dispatcher.ts Outdated Show resolved Hide resolved
packages/node-core/src/indexer/worker/worker.ts Show resolved Hide resolved
packages/node-core/src/subcommands/forceClean.service.ts Outdated Show resolved Hide resolved
@stwiname
Copy link
Collaborator

I think POI being enabled needs to set the size to non-zero. But we should determine the size based on the network project

jiqiang90 and others added 2 commits May 30, 2024 16:25
@jiqiang90 @stwiname
Admin api (#2415)
7386c05 
* draft

* rewind

* poi

* add tests

* add test for stop poi stop sync

* Update packages/node-core/src/indexer/blockDispatcher/base-block-dispatcher.ts

Co-authored-by: Scott Twiname <skott.twiname@gmail.com>

* address comment

* monitor service add exit

* Update packages/node-core/src/process.ts

Co-authored-by: Scott Twiname <skott.twiname@gmail.com>

* address comments

* change write

* update

* improve exit error

* fix rewind height issue

---------

Co-authored-by: Scott Twiname <skott.twiname@gmail.com>
@jiqiang90
set default monitor size to 200
28b2a0c
stwiname
stwiname reviewed May 31, 2024
View reviewed changes
packages/node-core/src/configure/NodeConfig.ts

get monitorFileSize(): number {
// Disable monitor file size if proofOfIndex is disabled
if (!this._config.proofOfIndex) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will always disable it rather than default to 0

packages/node-core/src/indexer/poi/poiSync.service.spec.ts Show resolved Hide resolved
packages/node-core/src/utils/project.ts Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stwiname stwiname stwiname left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jiqiang90 @stwiname