use same instance on symlinked modules #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 30, 2015
chrisirhc
force-pushed
the
feature/handle-symlinks
branch
from
ceaef13
to
504832b
Compare
|
Updated PR. Tests now pass. |
|
Aside from the sync issue, this looks good. We should just make sure to not re-introduce this bug: #831 |
ghost
merged commit
|
I added some tests for the case in #831 and everything works. Published in 10.2.5/10.2.6. Thanks for the patch! |
|
(Edit: moved problem to new issue: #1325) |
1 task
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle required packages by their real path.
Resolves #1063
Again, this is a request for further comment.
This isn't using a cache which might be faster (or not, since resolve might only be called for new packages encountered).