Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema Resume / Add Caya as experience #879

Merged
merged 5 commits into from
May 20, 2024
Merged

Conversation

suddenlyGiovanni
Copy link
Owner

No description provided.

Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: 52eaadd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@9138056). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             main    #879   +/-   ##
======================================
  Coverage        ?   4.04%           
======================================
  Files           ?      40           
  Lines           ?    3165           
  Branches        ?      43           
======================================
  Hits            ?     128           
  Misses          ?    3037           
  Partials        ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…esume-repository

This commits improves the flexibility of the getResume function by
allowing the user to specify a Git reference. By default, the reference
("ref") is set to 'main'. This change is aimed to enhance the repository
 handling functionalities.

Signed-off-by: Giovanni Ravalico <15946771+suddenlyGiovanni@users.noreply.github.com>
The resume fetching call in the Resume route of the web app has been
updated to include a specific parameter. This ensures the
ResumeRepository.getResume() function fetches the resume data in a more
controlled manner by using a specific schema.

Signed-off-by: Giovanni Ravalico <15946771+suddenlyGiovanni@users.noreply.github.com>
The padding for the roles list in the experience section of the resume
has been enhanced. Changes were made to increase the left padding in
small and medium-sized screens, improving the mobile experience without
affecting larger screen views.

Signed-off-by: Giovanni Ravalico <15946771+suddenlyGiovanni@users.noreply.github.com>
The hardcoded 'schema-resume/add-caya' identifier was removed from the
getResume() call in the resume route. This change allows for a more
dynamic functionality, improving the overall flexibility of the
ResumeRepository.getResume() use case.

Signed-off-by: Giovanni Ravalico <15946771+suddenlyGiovanni@users.noreply.github.com>
Added a new function getDates to better handle start and end dates in
Experience module. This function replaces the previous method of
handling dates, allowing for more accurate and less error-prone date
management.

Signed-off-by: Giovanni Ravalico <15946771+suddenlyGiovanni@users.noreply.github.com>
@suddenlyGiovanni suddenlyGiovanni changed the title Schema resume/add caya Schema Resume / Add Caya as experience May 20, 2024
@suddenlyGiovanni suddenlyGiovanni marked this pull request as ready for review May 20, 2024 18:24
@suddenlyGiovanni suddenlyGiovanni merged commit 55c1bce into main May 20, 2024
14 of 15 checks passed
@suddenlyGiovanni suddenlyGiovanni deleted the schema-resume/add-caya branch May 20, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants