Upgrade $request->get('key') calls on array to $request->all('key'); (#…

…6587)
sulu · May 3, 2022 · a05e58a · a05e58a
1 parent 5718183
commit a05e58a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 14 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -42890,11 +42890,6 @@ parameters:
 			count: 1
 			path: src/Sulu/Bundle/SecurityBundle/Controller/ResettingController.php
 
-		-
-			message: "#^Argument of an invalid type float\\|int\\<min, \\-1\\>\\|int\\<1, max\\>\\|string\\|true supplied for foreach, only iterables are supported\\.$#"
-			count: 1
-			path: src/Sulu/Bundle/SecurityBundle/Controller/RoleController.php
-
 		-
 			message: "#^Call to an undefined method Doctrine\\\\ORM\\\\EntityRepository\\<SuluSecurityBundle\\:SecurityType\\>\\:\\:findSecurityTypeById\\(\\)\\.$#"
 			count: 1
@@ -43060,11 +43055,6 @@ parameters:
 			count: 1
 			path: src/Sulu/Bundle/SecurityBundle/Controller/RoleController.php
 
-		-
-			message: "#^Parameter \\#2 \\$default of method Symfony\\\\Component\\\\HttpFoundation\\\\InputBag\\<bool\\|float\\|int\\|string\\>\\:\\:get\\(\\) expects bool\\|float\\|int\\|string\\|null, array given\\.$#"
-			count: 1
-			path: src/Sulu/Bundle/SecurityBundle/Controller/RoleController.php
-
 		-
 			message: "#^Parameter \\#2 \\$value of method Sulu\\\\Component\\\\Rest\\\\ListBuilder\\\\ListBuilderInterface\\:\\:where\\(\\) expects string, false given\\.$#"
 			count: 1

diff --git a/src/Sulu/Bundle/SecurityBundle/Controller/RoleController.php b/src/Sulu/Bundle/SecurityBundle/Controller/RoleController.php
@@ -230,14 +230,15 @@ public function postAction(Request $request)
             $role->setKey($key);
             $role->setSystem($system);
 
-            $permissions = $request->request->get('permissions');
+            $permissions = $request->request->all('permissions');
+
             if (!empty($permissions)) {
                 foreach ($permissions as $permissionData) {
                     $this->addPermission($role, $permissionData);
                 }
             }
 
-            $securityTypeData = $request->request->get('securityType');
+            $securityTypeData = $request->request->all('securityType');
             if ($this->checkSecurityTypeData($securityTypeData)) {
                 $this->setSecurityType($role, $securityTypeData);
             }
@@ -285,11 +286,11 @@ public function putAction(Request $request, $id)
                 $role->setKey($key);
                 $role->setSystem($system);
 
-                if (!$this->processPermissions($role, $request->request->get('permissions', []))) {
+                if (!$this->processPermissions($role, $request->request->all('permissions'))) {
                     throw new RestException('Could not update dependencies!');
                 }
 
-                $securityTypeData = $request->request->get('securityType');
+                $securityTypeData = $request->request->all('securityType');
                 if ($this->checkSecurityTypeData($securityTypeData)) {
                     $this->setSecurityType($role, $securityTypeData);
                 } else {