Add symfony 3.4.12 as conflict to fix caching tests #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danrot
force-pushed
the
bugfix/symfony-update-audience-targeting
branch
from
bc0087d
to
48c54b8
Compare
danrot
commented
Jun 26, 2018
| @@ -54,7 +54,7 @@ | |||
|
|
|||
| <service id="sulu_security.authentication_handler" class="%sulu_security.authentication_handler.class%"> | |||
| <argument type="service" id="router"/> | |||
| <argument type="service" id="session"/> | |||
| <argument type="service" id="session" on-invalid="null"/> | |||
There was a problem hiding this comment.
That's actually not really nice, but I can't find a better way of doing this 😕
danrot
added
the
Bug
danrot
force-pushed
the
bugfix/symfony-update-audience-targeting
branch
from
d8cb950
to
ebaa4aa
Compare
|
Just writing a conflict now, since symfony/symfony#27714 should fix that. |
danrot
force-pushed
the
bugfix/symfony-update-audience-targeting
branch
from
ebaa4aa
to
48693d3
Compare
danrot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR fixes a regression introduced by symfony/symfony#27467.
Why?
Because the tests should actually run :-)