-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AdminBundle: Add ColorFieldTransformer #5555
AdminBundle: Add ColorFieldTransformer #5555
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FarouHub Thank you for this PR. We should also add a test for this new transformer see for example IconTransformer.test.js
...u/Bundle/AdminBundle/Resources/js/containers/List/fieldTransformers/ColorFieldTransformer.js
Outdated
Show resolved
Hide resolved
… colorFieldTransformer.scss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me otherwise - thanks a lot for your effort! 🙂
...u/Bundle/AdminBundle/Resources/js/containers/List/fieldTransformers/ColorFieldTransformer.js
Outdated
Show resolved
Hide resolved
...u/Bundle/AdminBundle/Resources/js/containers/List/fieldTransformers/ColorFieldTransformer.js
Outdated
Show resolved
Hide resolved
...u/Bundle/AdminBundle/Resources/js/containers/List/fieldTransformers/ColorFieldTransformer.js
Show resolved
Hide resolved
...Bundle/AdminBundle/Resources/js/containers/List/fieldTransformers/colorFieldTransformer.scss
Outdated
Show resolved
Hide resolved
…Transformers/ColorFieldTransformer.js Co-authored-by: nnatter <niklas.natter@gmail.com>
…Transformers/ColorFieldTransformer.js Co-authored-by: nnatter <niklas.natter@gmail.com>
…Transformers/ColorFieldTransformer.js Co-authored-by: nnatter <niklas.natter@gmail.com>
…Transformers/colorFieldTransformer.scss Co-authored-by: nnatter <niklas.natter@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adjusted the error message a bit, hope that is okay for you. Thanks for your effort! 🙂
The CircleCI error is not related to this PR (see #5569) |
What's in this PR?
Add a ColorFieldTransformer form the AdminBundle.
With this transformer we will have the ability to view/show the color choose with the "Color content type" into the admin table list.
Why?
Many users are asking to this option.
Example Usage