Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaggedServiceCollectorCompilerPass -> tagged_iterator #7424

Open
wants to merge 3 commits into
base: 2.6
Choose a base branch
from

Conversation

mamazu
Copy link
Contributor

@mamazu mamazu commented May 15, 2024

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Fixed tickets refs #7402
Related issues/PRs -
License MIT
Documentation PR -

What's in this PR?

Replacing the Sulu implementation of tagged iterators with the Symfony one.

Why?

We don't need to reinvent the wheel.

Example usage

Before you had to have this in the bundle configuration:

         $container->addCompilerPass(
            new TaggedServiceCollectorCompilerPass(
                'sulu_markup.link_tag.provider_pool',
                'sulu.link.provider',
                0,
                'alias'
            )
        );

Now Sulu uses this:

<service id="sulu_markup.link_tag.provider_pool" class="..." />
    <argument type="tagged_iterator" tag="sulu.link.provider" indexed-by="alias" />
</service>

To Do

  • Add breaking changes to UPGRADE.md

@mamazu mamazu marked this pull request as draft May 15, 2024 16:09
@mamazu mamazu force-pushed the tagged_iterator_implementation branch 2 times, most recently from ba1ed61 to d5ffe58 Compare May 15, 2024 16:27
@mamazu mamazu force-pushed the tagged_iterator_implementation branch 4 times, most recently from f664669 to 6b0731e Compare May 16, 2024 09:50
@mamazu mamazu force-pushed the tagged_iterator_implementation branch from 6b0731e to a102d13 Compare May 16, 2024 15:56
@mamazu mamazu changed the title Replacing TaggedServiceCollectorCompilerPass with TaggedServiceCollectorCompilerPass -> tagged_iterator May 17, 2024
@mamazu mamazu marked this pull request as ready for review May 17, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant