Fix color contrast of tertiary Button underline #2400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ef835aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2400 +/- ##
=======================================
Coverage ? 87.76%
=======================================
Files ? 198
Lines ? 21251
Branches ? 1316
=======================================
Hits ? 18652
Misses ? 2547
Partials ? 52 |
This comment was marked as outdated.
This comment was marked as outdated.
connor-baer
force-pushed
the
fix/tertiary-button-underline
branch
from
cb7dd12
to
ef835aa
Compare
|
Closing in favor of an upcoming pull request that will address this and other usability issues in the new buttons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The underline of the Button's tertiary variant doesn't meet color contrast requirements.
Approach and changes
var(--cui-border-normal)(1.67:1) withvar(--cui-fg-subtle)(4.82:1)Definition of done