Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Calendar component's month navigation button styles #2514

Merged
merged 2 commits into from
May 17, 2024

Conversation

connor-baer
Copy link
Member

Approach and changes

  • Fix month navigation button styles: Vite orders the styles for experimental components before those of stable components, causing the custom styles applied to stable components to be overridden.
  • Deprecate the RangePickerController component in favor of the experimental Calendar component

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

Vite orders the styles for experimental components before those of stable components, causing the custom styles applied to stable components to be overridden.
@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label May 17, 2024
@connor-baer connor-baer requested a review from a team as a code owner May 17, 2024 17:49
Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: 32e5b63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 5:49pm

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 62.74510% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 88.15%. Comparing base (cc8fc91) to head (32e5b63).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2514      +/-   ##
==========================================
- Coverage   88.18%   88.15%   -0.04%     
==========================================
  Files         204      204              
  Lines       22282    22298      +16     
  Branches     1489     1489              
==========================================
+ Hits        19650    19656       +6     
- Misses       2580     2590      +10     
  Partials       52       52              
Files Coverage Δ
...ckages/circuit-ui/components/Calendar/Calendar.tsx 95.68% <100.00%> (+0.01%) ⬆️
...mponents/legacy/Calendar/RangePickerController.tsx 62.74% <24.00%> (-12.94%) ⬇️

@connor-baer connor-baer merged commit 8217e7b into main May 17, 2024
11 of 14 checks passed
@connor-baer connor-baer deleted the fix/calendar-styles branch May 17, 2024 17:53
@connor-baer connor-baer mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🗂 circuit-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant