Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint to 5 (Major) #11

Merged
merged 4 commits into from Jun 25, 2018

Conversation

papandreou
Copy link
Collaborator

@papandreou papandreou commented Jun 23, 2018

It currently works, except for the unmet peer dep (which makes npm install fail with npm 2.x/node.js 4), and this warning:

(node:29919) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in "pretty-standard")

I suggest dropping support for earlier eslint versions so that we can avoid conditionally applying this patch:

standard/eslint-config-standard@6a89a51

TODO:

papandreou added a commit to papandreou/express-processimage that referenced this pull request Jun 23, 2018
Copy link
Owner

@sunesimonsen sunesimonsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a major version bump

@papandreou
Copy link
Collaborator Author

Yeah, agreed (I put it in the title of the PR :)

@sunesimonsen
Copy link
Owner

@papandreou I added you and @gustavnikolaj as collaborators and package owners, so just merge and release this 🚢

@papandreou papandreou changed the title Update eslint to 5 (semver-major) Update eslint to 5 Jun 23, 2018
@sunesimonsen sunesimonsen changed the title Update eslint to 5 Update eslint to 5 (Major) Jun 23, 2018
@papandreou
Copy link
Collaborator Author

@sunesimonsen, thanks a bunch!

@sunesimonsen
Copy link
Owner

sunesimonsen commented Jun 23, 2018

It is nice to have major in the title if we are going for a changelog.

That makes it much easier to see which PR's is breaking.

@papandreou
Copy link
Collaborator Author

@sunesimonsen, I changed it to a label, but that's a good point, let's keep it in the title as well :)

@papandreou
Copy link
Collaborator Author

jsx-eslint/eslint-plugin-react#1843 was merged, awaiting a new release.

@papandreou papandreou merged commit 26ffe30 into sunesimonsen:master Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants