New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eslint to 5 (Major) #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a major version bump
Yeah, agreed (I put it in the title of the PR :) |
@papandreou I added you and @gustavnikolaj as collaborators and package owners, so just merge and release this 🚢 |
@sunesimonsen, thanks a bunch! |
It is nice to have major in the title if we are going for a changelog. That makes it much easier to see which PR's is breaking. |
@sunesimonsen, I changed it to a label, but that's a good point, let's keep it in the title as well :) |
jsx-eslint/eslint-plugin-react#1843 was merged, awaiting a new release. |
It currently works, except for the unmet peer dep (which makes
npm install
fail with npm 2.x/node.js 4), and this warning:I suggest dropping support for earlier eslint versions so that we can avoid conditionally applying this patch:
standard/eslint-config-standard@6a89a51
TODO: