Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the readme file #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lastmonk
Copy link
Contributor

No description provided.

Copy link
Owner

@sunishsurendrank sunishsurendrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jijo,

Thanks for your contribution!!!!! Really appreciate.

I have a few comments on your changes.

1. Change the name of the "output.txt" to "pythonscript.log"
2. "f" is not a good way of declaring a variable, please mention it as "logfile"
3. I think no need to open the same "output.txt" in the helper.ps1 also, because it called from the
master
Script loaddb-fordocker.ps1
4. Better to add TimeStamp to the name of the log file. Also, create new log files in each run of the while loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants