Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ResourceWarnings into errors during tests #4692

Closed
wants to merge 1 commit into from

Conversation

dstansby
Copy link
Member

python by default ignores these, but we probably want to catch them in our tests (and there's a couple I spotted looking through the logs recently).

The full list is

ignore::DeprecationWarning
ignore::PendingDeprecationWarning
ignore::ImportWarning
ignore::ResourceWarning

Do we want to error on any of these other ones?

@dstansby dstansby added the Tests Affects tests in some measure label Nov 30, 2020
@nabobalis
Copy link
Contributor

Fixing these would be very good.

@dstansby
Copy link
Member Author

🤔 this did not trigger test errors like I thought it would

@dstansby dstansby marked this pull request as draft November 30, 2020 18:59
@dstansby
Copy link
Member Author

The lack of errors might be due to pytest-dev/pytest#5676

@dstansby
Copy link
Member Author

Looks like when pytest-dev/pytest#8055 winds its way into a pytest release we can revisit this.

@dstansby
Copy link
Member Author

I don't think we need this any more, as ResourceWarnings seem to be caught automatically by pytest 6.2

@dstansby dstansby closed this Dec 13, 2020
@kakirastern
Copy link

🎉

@dstansby dstansby deleted the resource-error branch December 13, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests Affects tests in some measure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants