Merge pull request #51 from peter279k/improve_assertions

Improve PHPUnit assertions
sunrise-php · Nov 30, 2021 · d068f41 · d068f41
2 parents 54e5b75 + 0a69cd9
commit d068f41
Show file tree

Hide file tree

Showing 3 changed files with 76 additions and 76 deletions.
diff --git a/tests/UriFactoryTest.php b/tests/UriFactoryTest.php
@@ -22,7 +22,7 @@ public function testCreateUri()
 
         $this->assertInstanceOf(UriInterface::class, $uri);
 
-        $this->assertEquals('/', $uri->getPath());
+        $this->assertSame('/', $uri->getPath());
     }
 
     public function testCreateUriWithoutUri()
@@ -31,7 +31,7 @@ public function testCreateUriWithoutUri()
 
         $this->assertInstanceOf(UriInterface::class, $uri);
 
-        $this->assertEquals('', $uri->getPath());
+        $this->assertSame('', $uri->getPath());
     }
 
     public function testCreateUriWithEmptyUri()
@@ -40,6 +40,6 @@ public function testCreateUriWithEmptyUri()
 
         $this->assertInstanceOf(UriInterface::class, $uri);
 
-        $this->assertEquals('', $uri->getPath());
+        $this->assertSame('', $uri->getPath());
     }
 }
diff --git a/tests/UriParserTest.php b/tests/UriParserTest.php
@@ -29,62 +29,62 @@ public function testGetScheme()
     {
         $uri = new UriParser(self::TEST_URI);
 
-        $this->assertEquals('scheme', $uri->getScheme()->present());
+        $this->assertSame('scheme', $uri->getScheme()->present());
     }
 
     public function testGetUser()
     {
         $uri = new UriParser(self::TEST_URI);
 
-        $this->assertEquals('user', $uri->getUser()->present());
+        $this->assertSame('user', $uri->getUser()->present());
     }
 
     public function testGetPass()
     {
         $uri = new UriParser(self::TEST_URI);
 
-        $this->assertEquals('pass', $uri->getPass()->present());
+        $this->assertSame('pass', $uri->getPass()->present());
     }
 
     public function testGetHost()
     {
         $uri = new UriParser(self::TEST_URI);
 
-        $this->assertEquals('host', $uri->getHost()->present());
+        $this->assertSame('host', $uri->getHost()->present());
     }
 
     public function testGetPort()
     {
         $uri = new UriParser(self::TEST_URI);
 
-        $this->assertEquals(3000, $uri->getPort()->present());
+        $this->assertSame(3000, $uri->getPort()->present());
     }
 
     public function testGetPath()
     {
         $uri = new UriParser(self::TEST_URI);
 
-        $this->assertEquals('/path', $uri->getPath()->present());
+        $this->assertSame('/path', $uri->getPath()->present());
     }
 
     public function testGetQuery()
     {
         $uri = new UriParser(self::TEST_URI);
 
-        $this->assertEquals('query', $uri->getQuery()->present());
+        $this->assertSame('query', $uri->getQuery()->present());
     }
 
     public function testGetFragment()
     {
         $uri = new UriParser(self::TEST_URI);
 
-        $this->assertEquals('fragment', $uri->getFragment()->present());
+        $this->assertSame('fragment', $uri->getFragment()->present());
     }
 
     public function testGetUserInfo()
     {
         $uri = new UriParser(self::TEST_URI);
 
-        $this->assertEquals('user:pass', $uri->getUserInfo()->present());
+        $this->assertSame('user:pass', $uri->getUserInfo()->present());
     }
 }