Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep alive tcp connection when downloading binary #1791

Merged
merged 1 commit into from Dec 29, 2023

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Dec 29, 2023

What kind of change does this PR introduce?

relates to #1769

What is the new behavior?

Reuse the same tcp connection for downloading multiple files from github release.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner December 29, 2023 16:28
@coveralls
Copy link

coveralls commented Dec 29, 2023

Pull Request Test Coverage Report for Build 7358578495

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 58.295%

Totals Coverage Status
Change from base Build 7355122520: 0.0%
Covered Lines: 6005
Relevant Lines: 10301

💛 - Coveralls

@sweatybridge sweatybridge changed the title fix: remove node-fetch from postinstall script fix: keep alive tcp connection when downloading binary Dec 29, 2023
@sweatybridge sweatybridge merged commit 2ddb04f into main Dec 29, 2023
21 checks passed
@sweatybridge sweatybridge deleted the native-fetch branch December 29, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants