fix: ignore case when creating realtime url

supabase · Aug 29, 2022 · 331cce3 · 331cce3
1 parent 23ae1a8
commit 331cce3
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/src/SupabaseClient.ts b/src/SupabaseClient.ts
@@ -84,7 +84,7 @@ export default class SupabaseClient<
 
     const _supabaseUrl = stripTrailingSlash(supabaseUrl)
 
-    this.realtimeUrl = `${_supabaseUrl}/realtime/v1`.replace('http', 'ws')
+    this.realtimeUrl = `${_supabaseUrl}/realtime/v1`.replace(/^http/i, 'ws')
     this.authUrl = `${_supabaseUrl}/auth/v1`
     this.storageUrl = `${_supabaseUrl}/storage/v1`
 

diff --git a/test/client.test.ts b/test/client.test.ts
@@ -28,6 +28,35 @@ describe('Custom Headers', () => {
   })
 })
 
+describe('Realtime url', () => {
+  test('should switch protocol from http to ws', () => {
+    const client = createClient('http://localhost:3000', KEY)
+
+    // @ts-ignore
+    const realtimeUrl = client.realtimeUrl
+
+    expect(realtimeUrl).toEqual('ws://localhost:3000/realtime/v1')
+  })
+
+  test('should switch protocol from https to wss', () => {
+    const client = createClient('https://localhost:3000', KEY)
+
+    // @ts-ignore
+    const realtimeUrl = client.realtimeUrl
+
+    expect(realtimeUrl).toEqual('wss://localhost:3000/realtime/v1')
+  })
+
+  test('should ignore case', () => {
+    const client = createClient('HTTP://localhost:3000', KEY)
+
+    // @ts-ignore
+    const realtimeUrl = client.realtimeUrl
+
+    expect(realtimeUrl).toEqual('ws://localhost:3000/realtime/v1')
+  })
+})
+
 // Socket should close when there are no open connections
 // https://github.com/supabase/supabase-js/issues/44