Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @supabase/postgres-meta in studio #11844

Merged
merged 12 commits into from
Jan 27, 2023
Merged

Update @supabase/postgres-meta in studio #11844

merged 12 commits into from
Jan 27, 2023

Conversation

ruggi99
Copy link
Contributor

@ruggi99 ruggi99 commented Jan 22, 2023

What kind of change does this PR introduce?

Chore: Upgrade @supabase/postgres-meta to v0.60.0

Also resolves this annoying warning:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@supabase/postgres-meta@0.26.1',
npm WARN EBADENGINE   required: { node: '>=14 <15', npm: '>=7' },
npm WARN EBADENGINE   current: { node: 'v18.13.0', npm: '8.19.3' }
npm WARN EBADENGINE }

Had to downgrade pgsql-parser to v13.4.0 because dependency libpg-query last version pre-built is v13.3.0 on https://supabase-public-artifacts-bucket.s3.amazonaws.com/ at the moment.

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@ruggi99 ruggi99 requested a review from a team as a code owner January 22, 2023 17:53
@vercel
Copy link

vercel bot commented Jan 22, 2023

@ruggi99 is attempting to deploy a commit to the Supabase Team on Vercel.

A member of the Team first needs to authorize it.

@ruggi99
Copy link
Contributor Author

ruggi99 commented Jan 22, 2023

PR blocked until supabase/postgres-meta#481 merged or relative issue fixed.
EDIT: PR merged, waiting for a new release

@ruggi99
Copy link
Contributor Author

ruggi99 commented Jan 27, 2023

@sweatybridge please mind that overrides do not work very well in monorepos.
That's why I manually updated package-lock.json
npm/cli#4232
npm/cli#5850

@sweatybridge
Copy link
Contributor

I found this issue npm/cli#4232 which suggested the following fixes:

  1. place overrides in root package.json
  2. uninstall the dependency first before saving
npm uninstall @supabase/postgres-meta
npm i --save-dev @supabase/postgres-meta@^0.60.2

This made the package-lock.json honour the overrides properly.

This reverts commit f4fb035.
@ruggi99
Copy link
Contributor Author

ruggi99 commented Jan 27, 2023

Hope it works, npm is very tricky

@sweatybridge
Copy link
Contributor

Yea, we should be updating the artefacts bucket soon anyway.

@sweatybridge sweatybridge merged commit 32b024e into supabase:master Jan 27, 2023
@ruggi99 ruggi99 deleted the update-postgres-meta branch January 27, 2023 06:59
@ruggi99
Copy link
Contributor Author

ruggi99 commented Jan 27, 2023

@sweatybridge
Lines added to Dockerfile were there because it fails to build on arm64.
Next time you build docker studio image it should fail.
At least you know what is the fix to apply in case.

@sweatybridge
Copy link
Contributor

sweatybridge commented Jan 27, 2023

I see. It was working for x86 so I assumed it was ok. Let me add it back

@ruggi99
Copy link
Contributor Author

ruggi99 commented Jan 27, 2023

Yeah, this is due public artifacts never available for arm64, that's why it was working on x86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants