Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support react-redux v7 #287

Closed
OliverJAsh opened this issue Apr 9, 2019 · 15 comments
Closed

Support react-redux v7 #287

OliverJAsh opened this issue Apr 9, 2019 · 15 comments

Comments

@OliverJAsh
Copy link
Contributor

v7 just came out: https://github.com/reduxjs/react-redux/releases/tag/v7.0.1

Currently we're tied to v6:

"react-redux": "^6.0.0",

@mdebeus
Copy link

mdebeus commented Apr 12, 2019

I am waiting for this as well - thank you for opening this.
Please upgrade to react-router 5.0 as well - you are currently tied to v4:

"react-router": "^4.3.1",

@supasate
Copy link
Owner

I tested and it seems like it's not backward compatible. I had no time to look through it yet, but, I think it may be related to the way it changed the subscription back from Context API to direct subscription (See #191 when it changed from direct subscription to Context API).

I'll take a look during the weekend. In the meantime, PR is welcome.

@bugzpodder
Copy link

I upgraded to react-redux v7 and it seemed to work fine for me:

> yarn why react-redux
=> Found "react-redux@7.0.2"

> yarn why connected-react-router
=> Found "connected-react-router@6.4.0"

@belgattitude
Copy link

@supasate First thanks for the work you put into connected-react-router. Really helpful !

For information, looks it works for me with react-redux 7. Sorry I could not go deeper in the internal changes. Seems too complex for me ;) Thx again for great work, it's appreciated

@ee0pdt
Copy link

ee0pdt commented Apr 24, 2019

Most of the changes in #191 seem to relate to documentation. If anything needs reverting to support v7 it shouldn't be too bad. And I'd also like to thank @supasate for your work on this project!

@aenciso
Copy link

aenciso commented Apr 24, 2019

It is working for me with react-redux 7.0.2

@cmfcmf
Copy link
Contributor

cmfcmf commented May 4, 2019

I've created a PR to allow react-redux@7. However, passing a custom context does not currently work: #303

@cmfcmf
Copy link
Contributor

cmfcmf commented May 23, 2019

My fix for react-redux has been merged in reduxjs/react-redux#1278 and #303 will be ready once a new version of react-redux is released.

@fwh1990
Copy link

fwh1990 commented Jun 16, 2019

It seem that react-redux has published new version 7.1.0 a week ago

@Oblosys
Copy link

Oblosys commented Jun 21, 2019

Looks like #303 got replaced by #321, which seems about ready to be merged.

@supasate
Copy link
Owner

supasate commented Jul 2, 2019

Released in v6.5.0.

@supasate supasate closed this as completed Jul 2, 2019
@prepaka
Copy link

prepaka commented Jul 3, 2019

Hi @supasate,

Today I upgrade router related packages in my project after that, I am getting 2 errors while running the project.

Packages which are updated from and to versions

"connected-react-router": **"6.5.0"**, Upgraded from **"5.0.1"**
"react": **"16.8.6"**, Upgraded from **"16.8.2"**
"react-dom": **"16.8.6"**, Upgraded from **"16.8.2"**
"react-redux": **"7.1.0"**, Upgraded from **"5.1.1"**
"react-router-dom": **"5.0.1"**, Upgraded from **"4.3.1"**

The error which I am getting

  1. Uncaught Invariant Violation: Could not find "store" in either the context or props of "Connect(t)". Either wrap the root component in a , or explicitly pass "store" as a prop to "Connect(t)"

  2. Uncaught Error: Invariant failed: You should not use <withRouter(InjectIntl(Component)) /> outside a

image

Please let me know how to fix these 2 issues.

@BiosBoy
Copy link

BiosBoy commented Aug 2, 2019

The same issue here. Any updates yet?

@sergei-startsev
Copy link

@BiosBoy How can developers recreate the bug on their end? Please create a new issue and provide repro steps, include a copy of your code (or create a repro repository) and the full output of your run. Otherwise there's nothing to work on.

@clayrisser
Copy link

I'm having the same problem. @prepaka did you find a solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.