Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an invalid type definition #253

Merged
merged 2 commits into from Feb 12, 2019
Merged

Fix an invalid type definition #253

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6439f29
Fix wrong type definition
cometkim Feb 11, 2019
b9d3b67
Addressed review comment
cometkim Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.d.ts
View file
Open in desktop
Expand Up @@ -61,7 +61,7 @@ declare module 'connected-react-router' {
export function createMatchSelector<
S extends RouterRootState, Params extends { [K in keyof Params]?: string }
>(path: string): matchSelectorFn<S, Params>;
export function onLocationChanged(location: Location, action: RouterActionType, isFirstRendering: boolean = false)
export function onLocationChanged(location: Location, action: RouterActionType, isFirstRendering: boolean)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be marked as optional parameter isFirstRendering?: boolean

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It needs to be optional.

: LocationChangeAction;

export type Push = typeof push;
Expand Down