Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prop-types: declare as a peer dependency #265

Merged
merged 1 commit into from Mar 3, 2019
Merged

prop-types: declare as a peer dependency #265

merged 1 commit into from Mar 3, 2019

Commits on Mar 1, 2019

  1. prop-types: declare as a peer dependency 

    create-react-app when building with yarn:

```
 $ react-scripts start
 Starting the development server...

 Failed to compile.

 /usr/local/share/.cache/yarn/v4/npm-connected-react-router-5.0.1-8379854fad7e027b1e27652c00ad534f8ad244b3/node_modules/connected-react-router/lib/ConnectedRouter.js
 Module not found: Package "connected-react-router@5.0.1" (via "/usr/local/share/.cache/yarn/v4/npm-connected-react-router-5.0.1-8379854fad7e027b1e27652c00ad534f8ad244b3/node_modules/connected-react-router/lib/ConnectedRouter.js") is trying to require the package "prop-types" (via "prop-types") without it being listed in its dependencies (history, react, react-redux, react-router, redux, immutable, seamless-immutable, connected-react-router)
``
    @avindra
    avindra committed Mar 1, 2019
    Copy the full SHA
    820e9f2 View commit details
    Browse the repository at this point in the history