Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move prop-types from peerDependencies into dependencies #281

Merged
merged 3 commits into from Apr 14, 2019
Merged

Move prop-types from peerDependencies into dependencies #281

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e89682
Remove prop-types from peerDependencies
cmfcmf Mar 28, 2019
6f3e480
Update prop-types to ^15.7.2
cmfcmf Apr 1, 2019
ffab3fe
Merge branch 'master' into prop-types
supasate Apr 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Expand Up @@ -29,11 +29,11 @@
},
"dependencies": {
"immutable": "^3.8.1",
"prop-types": "^15.5.7",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help upgrade it to ^15.7.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

"seamless-immutable": "^7.1.3"
},
"peerDependencies": {
"history": "^4.7.2",
"prop-types": "^15.0.0 || ^16.0.0",
"react": "^16.4.0",
"react-redux": "^6.0.0",
"react-router": "^4.3.1",
Expand Down Expand Up @@ -61,7 +61,6 @@
"eslint-plugin-import": "^2.14.0",
"eslint-plugin-react": "^7.11.1",
"jest": "^24.3.1",
"prop-types": "^15.5.8",
"raf": "^3.4.0",
"react": "^16.4.0",
"react-dom": "^16.0.0",
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop
Expand Up @@ -5526,7 +5526,7 @@ prompts@^2.0.1:
kleur "^3.0.2"
sisteransi "^1.0.0"

prop-types@^15.5.7, prop-types@^15.5.8, prop-types@^15.6.1, prop-types@^15.6.2:
prop-types@^15.5.7, prop-types@^15.6.1, prop-types@^15.6.2:
version "15.6.2"
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.6.2.tgz#05d5ca77b4453e985d60fc7ff8c859094a497102"
integrity sha512-3pboPvLiWD7dkI3qf3KbUe6hKFKa52w+AE0VCqECtf+QHAKgOL37tTaNCnuX1nAAQ4ZhyP+kYVKf8rLmJ/feDQ==
Expand Down