Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix history listener #476

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

kale1d0code
Copy link

@kale1d0code kale1d0code commented Feb 1, 2021

Hi amazing library can't wait to use it

however whenever I changed location my app crashed mentioning it could not find the router reducer. after some debugging I found the actions payload was malformed
it had no history action and its location was an object of the values for action and location.

looking over at the history.js project, it expects its listeners to take an object which includes location and action properties, your listener expects these values to be their own parameters.

@kale1d0code
Copy link
Author

turns out I'm using the wrong version of history but I'll work on this so your project can work on history v5

@bbortt
Copy link

bbortt commented Feb 5, 2021

@kale1d0code are you working on it? the peer deps change is missing:

"peerDependencies": {
+    "history": "^5.0.0",
-    "history": "^4.7.2",
    [...]

I could push it if you want me to.
would solve #312.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants