Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade to graphql 15.8.0 to match express-graphql peer #4

Merged
merged 2 commits into from Jan 11, 2022

Conversation

freaz
Copy link
Member

@freaz freaz commented Jan 11, 2022

I have reached GraphQL folks on Discord, and they should be fixing urgent things on graphql projects. So hopefully they will soon get to express-graphql as well. Meanwhile I downgraded graphql package to supported version by express-graphql as we are not using anything from newer versions.

Before:
image

After:
image

@freaz freaz requested a review from jnv January 11, 2022 12:29
@jnv
Copy link
Contributor

jnv commented Jan 11, 2022

That snapshot change is weird but other than that :shipit:!

@freaz
Copy link
Member Author

freaz commented Jan 11, 2022

I had to look why, and it is change in graphql/graphql-js#3375

@freaz freaz merged commit b088ebf into main Jan 11, 2022
@freaz freaz deleted the fix/resolve_dependencies branch January 11, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants