Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google.golang.org/genproto to latest #2690

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

usrme
Copy link
Contributor

@usrme usrme commented Aug 14, 2023

Change Summary

What and Why:

This upgrades google.golang.org/genproto to the latest available version to avoid "ambiguous import" errors as described here, which causes issues when trying to build the project currently at the tip:

$ make build
Running Generate for Help and GraphQL client
go generate ./...
Running Build
CGO_ENABLED=0 go build -o bin/flyctl -ldflags="-X 'github.com/superfly/flyctl/internal/buildinfo.buildDate=2023-08-14T12:19:06Z' -X 'github.com/superfly/flyctl/internal/buildinfo.branchName=master'" .
/home/usrme/go/pkg/mod/google.golang.org/grpc@v1.55.0/status/status.go:35:2: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/status in multiple modules:
        google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 (/home/usrme/go/pkg/mod/google.golang.org/genproto@v0.0.0-20230410155749-daa745c078e1/googleapis/rpc/status)
        google.golang.org/genproto/googleapis/rpc v0.0.0-20230530153820-e85fd2cbaebc (/home/usrme/go/pkg/mod/google.golang.org/genproto/googleapis/rpc@v0.0.0-20230530153820-e85fd2cbaebc/status)
make: *** [Makefile:12: build] Error 1

How:

$ go get google.golang.org/genproto@latest
...
$ go mod tidy
...

Related to:

googleapis/go-genproto#1015

Copy link
Member

@kzys kzys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@kzys kzys merged commit a6057ec into superfly:master Aug 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants