Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use require.Eventually instead of require.EventuallyWithT #2760

Merged
merged 1 commit into from Aug 29, 2023
Merged

Use require.Eventually instead of require.EventuallyWithT #2760

merged 1 commit into from Aug 29, 2023

Conversation

michaeldwan
Copy link
Member

@michaeldwan michaeldwan commented Aug 29, 2023 •
edited

@michaeldwan
Use require.Eventually instead of require.EventuallyWithT
b3af6e2 
It seems that some assertions will call `FailNow()` which panics when called on `assert.CollectT`.

See:
- stretchr/testify#1396
- stretchr/testify#1457
@michaeldwan michaeldwan marked this pull request as ready for review August 29, 2023 23:41
@michaeldwan michaeldwan merged commit 520cecf into master Aug 29, 2023
37 checks passed
@michaeldwan michaeldwan deleted the avoid-panic-in-testify branch August 29, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@michaeldwan