Add Filament Cache Command through Laravel Scanner's Dockerfile Template #3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johannes-Werbrouck
approved these changes
Mar 4, 2024
| @@ -3,3 +3,9 @@ | |||
| /usr/bin/php /var/www/html/artisan config:cache --no-ansi -q | |||
| /usr/bin/php /var/www/html/artisan route:cache --no-ansi -q | |||
| /usr/bin/php /var/www/html/artisan view:cache --no-ansi -q | |||
|
|
|||
| # Filament v3.2 Performance Improvement with commands | |||
| if grep "filament/filament.*:.*3\.2" "/var/www/html/composer.json"; then | |||
There was a problem hiding this comment.
Not sure if you need the options -Fq here as well? (you probably don't)
-F disables regex searching, so would make sense to remove.
-q makes the command quiet, not sure what impact this would have.
There was a problem hiding this comment.
removed the options
Hey @Johannes-Werbrouck ! Thanks for checking in! Noted on the above |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
What: Run Filament Cache command when Filament is installed for a Laravel application
Why: Thanks to community post, it was discovered that Laravel apps with Filament installed get really low requests per second( I tested, and got 5 requests per second ). This can be improved by running Filament's cache commands.
How:
Revise Laravel's Dockerfile template to run the Filament cache commands when "filament/filament" is detected in the composer.json file
Related to:
Community post
Documentation