Add FailureCallback for Laravel Scanner, displaying advise on upgrading to latest flyctl version #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
Include a FailureCallback for the Laravel scanner. There are cases when launch fails for Laravel apps. Sometimes these issues are already fixed in more recent versions of flyctl, so display advise prompting user to upgrade their flyctl scanner to latest version.
How:
Include a FailureCallback function for Laravel scanner at LaravelFailureCallback. Set the
flyerr.GenericErr.Suggestvalue to string prompting for version upgrade.Very similar to Rails Callback! Thanks for pointing this out @rubys !
TODO:
Create a docs page in Laravel section of Fly.io docs to include a list of common launch issues and their fixes. similar to https://fly.io/docs/rails/getting-started/existing/#common-initial-deployment-issues
THEN finalize this PR with a link to that new page.
Related to:
Launch errors for Laravel apps
Documentation