-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support fly config in json and yaml formats #3545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Come to say I love the work you are doing here, adding json and yaml support is awesome but please add unit tests. TOML is well tested now, not perfect but covers many legacy stuff that we don't want to break. I'd like to see a similar level of test coverage for yaml and json.
@dangra If you look in testdata, you will now see full-reference in all three formats. There were produced using This demonstrates that configurations can round-trip in all three formats. Any other suggestions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fly launch
using the configuration of your choice -- toml remains the default, but--json
or--yaml
can be specified to select an alternate format.Or convert at any time using
fly config show --local
and specify--yaml
or--toml
and redirect the output to a file with the correct file extension. (json remains the default for this command). Just remember to delete the other representation -- the search order is fly.toml, then fly.json, then fly.yaml.fly config save
can also be used (it defaults to toml).