Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set HTTPS Failover to true by defualt #3546

Merged
merged 1 commit into from
May 16, 2024
Merged

Set HTTPS Failover to true by defualt #3546

merged 1 commit into from
May 16, 2024

Conversation

billyb2
Copy link
Member

@billyb2 billyb2 commented May 14, 2024

Change Summary

What and Why:
This commit does two things:

  1. We're now using HTTP failover by default, and seeing if it helps with remote builder connections. The original plan was to use flyctl feature flags, but plans change ¯_(ツ)_/¯
  2. We're renaming HTTP failover to HTTPS failover, and keeping http-failover as an alias. It's a bit more accurate to what's happening

How:

Related to:


Documentation

  • Fresh Produce
  • In superfly/docs, or asked for help from docs team
  • n/a

This commit does two things:
1. We're now using HTTP failover by default, and seeing if it helps with
remote builder connections. The original plan was to use flyctl feature
flags, but plans change ¯\_(ツ)_/¯
2. We're renaming HTTP failover to HTTPS failover, and keeping
http-failover as an alias. It's a bit more accurate to what's happening
@billyb2 billyb2 marked this pull request as ready for review May 14, 2024 20:07
Copy link
Member

@dangra dangra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@billyb2 billyb2 merged commit 288351a into master May 16, 2024
43 checks passed
@billyb2 billyb2 deleted the http-failover-true branch May 16, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants