Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Postgres for Phoenix apps on fly launch #3548

Merged
merged 2 commits into from
May 15, 2024

Conversation

andreolvr
Copy link
Contributor

@andreolvr andreolvr commented May 14, 2024

Change Summary

I created a new Phoenix app with mix phx.new app --database postgres and fly launch failed since we are not putting Postgres on the launch plan.

This PR sets the s.DatabaseKind property, which puts Postgres on the launch plan and makes the launch succeed.


Documentation

  • Fresh Produce
  • In superfly/docs, or asked for help from docs team
  • n/a

@andreolvr andreolvr marked this pull request as ready for review May 14, 2024 23:12
scanner/phoenix.go Outdated Show resolved Hide resolved
Copy link
Contributor

@benbjohnson benbjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm minus the mysql/mssql comment.

scanner/phoenix.go Outdated Show resolved Hide resolved
@andreolvr andreolvr merged commit 0770cb7 into master May 15, 2024
39 checks passed
@andreolvr andreolvr deleted the andre/add-postgres-to-plan-on-phoenix-scanner branch May 15, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants