Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade markdown package to v7.2.0 #1907

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Maksimka101
Copy link

Additionally, I found a bug in the unordered list followd by empty list item test.

In previous versions of the markdown package, parsing this markdown - list item 1\n - resulted in the following structure:
A list (li) consisting of one item (ul). And in this item, there was a header (h2) containing the text list item 1

The header appeared in the first list item because during internal transformations, the text initially turned into list item 1\n - , which was then interpreted as header syntax. In the new version of the package, this behavior has been corrected, and now this markdown is parsed as a list with one item containing the text list item 1\n -

I modified the test to accurately reflect its description. That is, now it indeed contains a list of two items, the last of which is empty

@matthew-carroll
Copy link
Contributor

Thanks for the PR. At the moment, I'm working on typing inline Markdown and automatically converting it to attributions. We'll need to get that merged first and then see how it works with newer version of the markdown package. If things continue to work, then we can merge the upgraded dependency.

@Maksimka101
Copy link
Author

You are working on the markdown functionality, so you will update the markdown package to the latest version yourself, and my pull request is not needed. Did I understand correctly?

@matthew-carroll
Copy link
Contributor

No, I'm not going to upgrade to the latest version, because my work didn't need the latest version.

Once I merge my Markdown work, you'll need to rebase this PR against main and check again to make sure everything still compiles and tests pass with the latest version.

This is the PR we're waiting for: #1896

@matthew-carroll
Copy link
Contributor

We just merged in the other PR. Can you bring the latest from main and adjust as needed?

@Maksimka101
Copy link
Author

Thanks for notifying me. I'll update it. But probably not very soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants