This repository has been archived by the owner on May 3, 2023. It is now read-only.
Add Node 12 #8
Merged
Add Node 12 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,6 +3,7 @@ | |||
| { "tag": "6", "from": "node:6" }, | |||
| { "tag": "6-npm6.1", "from": "node:6", "extraInstructions": ["RUN npm install npm@6.1.x", "RUN rm -rf /usr/local/lib/node_modules/npm", "RUN mv node_modules/npm /usr/local/lib/node_modules/npm"] }, | |||
| { "tag": "8", "from": "node:8" }, | |||
| { "tag": "10", "from": "node:10" } | |||
| { "tag": "10", "from": "node:10" }, | |||
| { "tag": "12", "from": "node:12" } | |||
There was a problem hiding this comment.
For the explicit tag, could we just do a {"tag": "12.13.0", "from": "node:12.13.0"}?
There was a problem hiding this comment.
I think that would work, I just didn't know if that was something we wanted to do. Obviously, minor/patch versions come out more frequently than major ones, so we'd have to add new ones more often in order to stay up-to-date. I don't know how annoying it would be for people if I made a new "add 12.x.y" image every time they released a new one.
There was a problem hiding this comment.
I don't think we'd have to do every one, just the ones we felt were necessary. It's not like the major version ones get updated all the time anyways.
guitarislife87
approved these changes
Oct 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 12 went into LTS today (nodejs/node#29981) with 12.13.0. I confirmed that in Docker Hub,
12is pointing to12.13.0. So I think it's fine for us to include it in our options now?In my opinion, we should consider having more specific version tags here (12.13.0 rather than just 12), but maybe that's a topic for another time, since it would require more maintenance.