Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multistage docker build action in docker_publish.yml #875

Closed
wants to merge 5 commits into from

Conversation

bquan0
Copy link
Contributor

@bquan0 bquan0 commented Mar 31, 2023

Description

I replaced most of the docker build actions with a multistage build action that will build all the stages in one job. This is still a work in progress, and I haven't changed the housekeeping job or updated the image names for the jobs that run tests.

Motivation and Context

Using the multistage action was briefly mentioned here.
This PR is a proof of concept to see if the multistage build action can be used in the docker_publish.yml workflow and how it should be implemented. Let me know if I should branch off of the PR in the previous link since that one modifies the Dockerfile to include the install scripts.

Changes

This PR makes docker_publish.yml build the images with the multistage docker build action, which is simpler and uses caching of images to avoid building stages that have stayed the same since the last build.

Behavior

The current behavior is that there is a job for each stage of the Dockerfile, and each job is dependent on the previous job in the workflow. The new behavior is that there is one job that will build all the stages in the Dockerfile using the multistage docker build action.

@gonuke
Copy link
Member

gonuke commented May 1, 2023

Since this got folded in to #863, perhaps you can withdraw/close this PR?

@bquan0
Copy link
Contributor Author

bquan0 commented May 5, 2023

Closing this PR as requested.

@bquan0 bquan0 closed this May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants