Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the Docs Documentation #950

Draft
wants to merge 22 commits into
base: develop
Choose a base branch
from
Draft

Read the Docs Documentation #950

wants to merge 22 commits into from

Conversation

pshriwise
Copy link
Member

@pshriwise pshriwise commented Mar 1, 2024

Description

This PR includes a documentation site overhaul using a read the docs theme. I've translated most of the exisiting content as a pure addition to the repository (for now) to support a content review before proceeding to cleanup the files and git history.

Highlights of this are:

  • documentation versioning
  • familiarity (it's become fairly standard in the OSS community I'd say)
  • leveraging existing in-line documentation on the C++ API for DAGMC and UWUW

A rendered version of this draft content can be found here.

Motivation and Context

RTD is a well-known theme in the open-source community. The aim here is to provide familiarity as part of the new user experience with DAGMC

@pshriwise pshriwise marked this pull request as draft March 1, 2024 22:07
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pshriwise - this looks mostly good. A few comments, probably only one or two really substantive ones - and we can decide to tackle these in subsequent PRs, perhaps, in order to move this forward.

configure_file(${CMAKE_CURRENT_SOURCE_DIR}/requirements.txt ${CMAKE_CURRENT_BINARY_DIR}/requirements.txt COPYONLY)
configure_file(${CMAKE_CURRENT_SOURCE_DIR}/make.bat ${CMAKE_CURRENT_BINARY_DIR}/make.bat COPYONLY)
else()
message(WARNING "Doxygen is required to build the documentation for double-down.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
message(WARNING "Doxygen is required to build the documentation for double-down.")
message(WARNING "Doxygen is required to build the documentation for DAGMC.")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😬 clear lift there I suppose. Thanks!

docs/index.rst Outdated
Comment on lines 1 to 4
.. Double-Down documentation master file, created by
sphinx-quickstart on Fri Mar 26 13:29:08 2021.
You can adapt this file completely to your liking, but it should at least
contain the root `toctree` directive.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update from Double Down copy/paste

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Good catch. Thanks!

docs/index.rst Outdated
Comment on lines 9 to 12
DAGMC is a toolkit for performing Monte Carlo radiation transport simulations on
CAD-based geometry models. It is built on top of the MOAB mesh database. DAGMC
is developed and maintained by the Computationan Nuclear Engineering Research
Group (CNERG) at the University of Wisconsin -- Madison.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems light on front page content, even compared the relatively light current page? Is that intentional or expedient?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've renamed/repurposed the "Is DAGMC for you?" section to an Introduction to DAGMC and made it more prominent on the main page. Does that read better?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this file become irrelevant?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this file become irrelevant?

* visited_surface (bool)
* turned on when a surface interaction is handled either in surface crossing or reflection
* turned off immediately following the next ray fire
* last_uvw (unit direction vector)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* last_uvw (unit direction vector)
* `last_uvw` (unit direction vector)

* set following every ray fire to record direction of last ray_fire
* note: not reset for each history because is not used until after
the first ray_fire in each history
* last_nps (int)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* last_nps (int)
* `last_nps` (int)


.. _coreform_export:

Using the Coreform Cubit plugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in the cubit_basics?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be an RST file? I can't remember why its a TXT file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewrite this to reference the Cubit importer? standalone code is not really available anymore

@shimwell
Copy link
Member

resolved a simple conflict in the change log for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants