Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't distribute fixtures #8

Merged
merged 1 commit into from Dec 3, 2021
Merged

Don't distribute fixtures #8

merged 1 commit into from Dec 3, 2021

Conversation

benmccann
Copy link
Member

Hopefully this will fix the pnpm weirdness

@Conduitry
Copy link
Member

I'm not sure what this will do. IIRC this package is not published to npm, but is instead cloned from GitHub when running the action, thus the checked-in dist directory.

@dominikg
Copy link
Member

dominikg commented Dec 3, 2021

it hopefully prevents pnpm from pulling in everything when installing this package with github protocol, referenced in kit package.json here: https://github.com/sveltejs/kit/blob/96f156d75a4acabaf80ac5b30d2910a04778977e/package.json#L35

It's causing a problem with latest pnpm (>= 6.23.3) which introduced stricter rules for git hosted packages via pnpm/pnpm#4044 to fix pnpm/pnpm#4038

@pngwn
Copy link
Member

pngwn commented Dec 3, 2021

I don’t think it will hurt, I’m not convinced it will do anything but can see.

@pngwn pngwn merged commit e2c5574 into sveltejs:main Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants