fix: ignore indent for inline style tags (#415)

sveltejs · Mar 23, 2023 · 9714749 · 9714749
1 parent fe306ed
commit 9714749
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 16 deletions.
diff --git a/.changeset/gorgeous-buckets-train.md b/.changeset/gorgeous-buckets-train.md
@@ -0,0 +1,5 @@
+---
+"eslint-plugin-svelte": patch
+---
+
+fix: ignore indent for inline style tags in `svelte/indent` rule
diff --git a/src/rules/indent-helpers/svelte.ts b/src/rules/indent-helpers/svelte.ts
@@ -34,23 +34,28 @@ export function defineVisitor(context: IndentContext): NodeListener {
       node.children.forEach((n) => offsets.ignore(n))
     },
     SvelteElement(node: AST.SvelteElement) {
-      if (
-        (node.name.type !== "Identifier" && node.name.type !== "SvelteName") ||
-        !PREFORMATTED_ELEMENT_NAMES.includes(node.name.name)
-      ) {
-        if (node.endTag) {
-          offsets.setOffsetElementList(
-            node.children.filter(isNotEmptyTextNode),
-            node.startTag,
-            node.endTag,
-            1,
-          )
+      if (node.name.type === "Identifier" || node.name.type === "SvelteName") {
+        if (PREFORMATTED_ELEMENT_NAMES.includes(node.name.name)) {
+          const startTagToken = sourceCode.getFirstToken(node)
+          const endTagToken =
+            node.endTag && sourceCode.getFirstToken(node.endTag)
+          offsets.setOffsetToken(endTagToken, 0, startTagToken)
+          node.children.forEach((n) => offsets.ignore(n))
+          return
         }
-      } else {
-        const startTagToken = sourceCode.getFirstToken(node)
-        const endTagToken = node.endTag && sourceCode.getFirstToken(node.endTag)
-        offsets.setOffsetToken(endTagToken, 0, startTagToken)
-        node.children.forEach((n) => offsets.ignore(n))
+        if (node.name.name === "style") {
+          // Inline style tag
+          node.children.forEach((n) => offsets.ignore(n))
+          return
+        }
+      }
+      if (node.endTag) {
+        offsets.setOffsetElementList(
+          node.children.filter(isNotEmptyTextNode),
+          node.startTag,
+          node.endTag,
+          1,
+        )
       }
     },
     // ----------------------------------------------------------------------

diff --git a/tests/fixtures/rules/indent/valid/inline-style-tag-input.svelte b/tests/fixtures/rules/indent/valid/inline-style-tag-input.svelte
@@ -0,0 +1,8 @@
+<svg>
+  <style>
+    /* prettier-ignore */
+    .test {
+        fill: red;
+      }
+  </style>
+</svg>